Get rid of getCurrentIP#3
Open
teythoon wants to merge 3 commits intowebyast:masterfrom
teythoon:remove_getCurrentIP
Open
Get rid of getCurrentIP#3teythoon wants to merge 3 commits intowebyast:masterfrom teythoon:remove_getCurrentIP
teythoon wants to merge 3 commits intowebyast:masterfrom
teythoon:remove_getCurrentIP
Conversation
added 3 commits
September 19, 2011 13:57
There are several problems with getCurrentIP: - the method used to determine the IP is fragile at best since it returns the address of the interface that is able to reach an route to the target host - so it cannot be used to get the ip of a specific interface - it breaks if there is no route to the target host - it does not belong into the frontend There is a corresponding patch for the rest-service that adds the required functionality to the backend. I'll push it into my provide_actual_ipaddr branch on github.
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several problems with getCurrentIP:
address of the interface that is able to reach an route to the target host
There is a corresponding patch for the rest-service that adds the required
functionality to the backend. I'll push it into my provide_actual_ipaddr
branch on github.