Open
Conversation
We now track the first photo clicked, and stop once that one is found again
2d51cab to
9ebc18d
Compare
Contributor
Author
|
The test fails because the profile saved in the DO Space has been logged out of facebook. I've uploaded a new profile to |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
Facebook changed the XPath for selecting the first image in the
photospage, which with this PR gets autopilot going again. However, because the photos list wraps around (clicking next enough times will get you back to the start) there's no real end condition for this behaviour...Also in my tests I came across various different URL formats for photos pages depending on the source. They often don't match the regex we're looking for, which means the behaviour gets skipped. This PR doesn't deal with that case