Open
Conversation
Replace the strip-ansi package with an inline regex equivalent. The ANSI stripping regex is the same pattern used by strip-ansi v6, inlined to eliminate the dependency. Since client.js runs in the browser (bundled by webpack), the native Node.js util.stripVTControlCharacters API cannot be used here. Addresses webpack#465 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
evenstensberg
left a comment
There was a problem hiding this comment.
I prefer to keep strip ansi. Anything related to regex's is a security sink
Collaborator
|
I agree, this is a simple dependency that does one thing well, there is little to be gained by inlining it |
Member
|
@evenstensberg There is a good example how our issue PR is ignored, we should look how to disable it (due AI generated) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strip-ansiwith an inline regex equivalentChanges
client.js
require('strip-ansi')with an inlinestrip()function using thesame ANSI escape regex from
ansi-regexv5 (the version used by strip-ansi v6)client.jsruns in the browser (bundled by webpack), the native Node.jsutil.stripVTControlCharactersAPI cannot be used herepackage.json
strip-ansifrom dependenciesTesting
no-control-regexdisable for the ANSI regex literal)realistic multi compiler(reproduces onmain)Addresses #465