Add user/password elasticsearch authentication #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianaromagnoli
commented
Apr 9, 2025
| "doctrine/annotations": "^1.8", | ||
| "ramsey/uuid": "^3.8", | ||
| "webgriffe/amp-elasticsearch": "^2.1", | ||
| "webgriffe/amp-elasticsearch": "dev-allow-es-authentication", |
Member
Author
There was a problem hiding this comment.
This will be changed to require the correct release version of webgriffe/amp-elasticsearch
fabianaromagnoli
commented
Apr 9, 2025
| - "discovery.type=${ES_DISCOVERY_TYPE:-single-node}" | ||
| - "ES_JAVA_OPTS=${ES_JAVA_OPTS:--Xms512m -Xmx512m}" | ||
| - xpack.security.enabled=true | ||
| - action.destructive_requires_name= false # because in unit tests setup we delete all indexes, and wildcards and _all are not allowed with security enabled |
Member
Author
There was a problem hiding this comment.
This should be removed: it needs to work also with this restriction active. We use _all wildcard in tests/KernelTestCase.php:106, but we could remove that, reading all indexes first (I think the _all wildcard is allowed when reading), and deleting them one by one.
fabianaromagnoli
commented
Apr 9, 2025
| - method: 'setCredentials' | ||
| arguments: | ||
| - '%elasticsearch_user%' | ||
| - '%elasticsearch_password%' |
Member
Author
There was a problem hiding this comment.
What if someone is working with Elasticsearch without the security pack, meaning no user/password authentication is required? We need to ensure backward compatibility and support scenarios where a username and password are not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes ESB work when Elasticsearch has security pack enabled and requires authentication with username and password.