Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
This pull request appears to be a work-in-progress or debugging branch that modifies the GitHub Actions release workflow. The changes introduce debugging code that would block the release pipeline from completing.
Changes:
- Added
sleep infinitycommand to the existingpublish-extension-open-vsxjob - Created a duplicate job
publish-extension-open-vsx-selfhostwith identical functionality but also containing asleep infinitycommand
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:235
- This entire job
publish-extension-open-vsx-selfhostappears to be a duplicate of thepublish-extension-open-vsxjob above with only minor differences (different runner and action versions). It has the same name, same conditions, and same functionality, which will cause confusion. Additionally, it contains the samesleep infinitybug on line 221. This duplicate job should be removed unless there's a specific reason for having two identical Open VSX publishing jobs.
publish-extension-open-vsx-selfhost:
if: ${{ inputs.to_release == 'all' || inputs.to_release == 'extension' }}
name: ${{ inputs.dry_run == true && 'Dry Run - Open VSX Extensions' || 'Publish Open VSX Extensions' }}
needs: [build]
runs-on: rspack-ubuntu-22.04-large
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 1
ref: ${{ github.event.inputs.branch }}
submodules: true
- name: Setup Node
uses: ./.github/actions/setup-node
- name: Download Artifact
uses: actions/download-artifact@v4.1.7
with:
path: binaries
- name: Build and publish to Open VSX Registry
env:
OVSX_PAT: ${{ secrets.RSLINT_OVSX_PAT }}
run: |
sleep infinity
if [ "${{ inputs.dry_run }}" = "true" ]; then
echo "🚀 DRY RUN: Building and packaging for Open VSX Registry without publishing..."
if [ "${{ inputs.extension_type }}" = "pre-release" ]; then
pnpm publish:ovsx --prerelease --dry-run
else
pnpm publish:ovsx --dry-run
fi
else
if [ "${{ inputs.extension_type }}" = "pre-release" ]; then
pnpm publish:ovsx --prerelease
else
pnpm publish:ovsx
fi
fi
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/release.yml
Outdated
| env: | ||
| OVSX_PAT: ${{ secrets.RSLINT_OVSX_PAT }} | ||
| run: | | ||
| sleep infinity |
There was a problem hiding this comment.
This sleep infinity command will cause the workflow to hang indefinitely, blocking the release process. This appears to be debugging code that should be removed before merging.
| sleep infinity |
.github/workflows/release.yml
Outdated
| env: | ||
| OVSX_PAT: ${{ secrets.RSLINT_OVSX_PAT }} | ||
| run: | | ||
| sleep infinity |
There was a problem hiding this comment.
This sleep infinity command will cause the workflow to hang indefinitely, blocking the release process. This appears to be debugging code that should be removed before merging.
| sleep infinity |
5a563e1 to
741b324
Compare
741b324 to
c178f1f
Compare
Deploying rslint with
|
| Latest commit: |
5a563e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad265e00.rslint.pages.dev |
| Branch Preview URL: | https://p-deanjingshui-check-win.rslint.pages.dev |
bd59a5e to
9865b34
Compare
fix disk problem
9865b34 to
5a424dc
Compare
Summary
Related Links
Checklist