Skip to content

chore: fix disk problem#450

Open
deanjingshui wants to merge 1 commit intomainfrom
p/deanjingshui/check-win
Open

chore: fix disk problem#450
deanjingshui wants to merge 1 commit intomainfrom
p/deanjingshui/check-win

Conversation

@deanjingshui
Copy link
Collaborator

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 30, 2026 06:23
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request appears to be a work-in-progress or debugging branch that modifies the GitHub Actions release workflow. The changes introduce debugging code that would block the release pipeline from completing.

Changes:

  • Added sleep infinity command to the existing publish-extension-open-vsx job
  • Created a duplicate job publish-extension-open-vsx-selfhost with identical functionality but also containing a sleep infinity command
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:235

  • This entire job publish-extension-open-vsx-selfhost appears to be a duplicate of the publish-extension-open-vsx job above with only minor differences (different runner and action versions). It has the same name, same conditions, and same functionality, which will cause confusion. Additionally, it contains the same sleep infinity bug on line 221. This duplicate job should be removed unless there's a specific reason for having two identical Open VSX publishing jobs.
  publish-extension-open-vsx-selfhost:
    if: ${{ inputs.to_release == 'all' || inputs.to_release == 'extension' }}
    name: ${{ inputs.dry_run == true && 'Dry Run - Open VSX Extensions' || 'Publish Open VSX Extensions' }}
    needs: [build]
    runs-on: rspack-ubuntu-22.04-large
    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          fetch-depth: 1
          ref: ${{ github.event.inputs.branch }}
          submodules: true

      - name: Setup Node
        uses: ./.github/actions/setup-node

      - name: Download Artifact
        uses: actions/download-artifact@v4.1.7
        with:
          path: binaries

      - name: Build and publish to Open VSX Registry
        env:
          OVSX_PAT: ${{ secrets.RSLINT_OVSX_PAT }}
        run: |
          sleep infinity
          if [ "${{ inputs.dry_run }}" = "true" ]; then
            echo "🚀 DRY RUN: Building and packaging for Open VSX Registry without publishing..."
            if [ "${{ inputs.extension_type }}" = "pre-release" ]; then
              pnpm publish:ovsx --prerelease --dry-run
            else
              pnpm publish:ovsx --dry-run
            fi
          else
            if [ "${{ inputs.extension_type }}" = "pre-release" ]; then
              pnpm publish:ovsx --prerelease
            else
              pnpm publish:ovsx
            fi
          fi

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

env:
OVSX_PAT: ${{ secrets.RSLINT_OVSX_PAT }}
run: |
sleep infinity
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sleep infinity command will cause the workflow to hang indefinitely, blocking the release process. This appears to be debugging code that should be removed before merging.

Suggested change
sleep infinity

Copilot uses AI. Check for mistakes.
env:
OVSX_PAT: ${{ secrets.RSLINT_OVSX_PAT }}
run: |
sleep infinity
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sleep infinity command will cause the workflow to hang indefinitely, blocking the release process. This appears to be debugging code that should be removed before merging.

Suggested change
sleep infinity

Copilot uses AI. Check for mistakes.
@deanjingshui deanjingshui force-pushed the p/deanjingshui/check-win branch from 5a563e1 to 741b324 Compare January 30, 2026 06:24
@deanjingshui deanjingshui changed the title P/deanjingshui/check win chore: fix disk problem Jan 30, 2026
@deanjingshui deanjingshui force-pushed the p/deanjingshui/check-win branch from 741b324 to c178f1f Compare January 30, 2026 06:27
@cloudflare-workers-and-pages
Copy link

Deploying rslint with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5a563e1
Status: ✅  Deploy successful!
Preview URL: https://ad265e00.rslint.pages.dev
Branch Preview URL: https://p-deanjingshui-check-win.rslint.pages.dev

View logs

@deanjingshui deanjingshui force-pushed the p/deanjingshui/check-win branch 2 times, most recently from bd59a5e to 9865b34 Compare January 30, 2026 12:58
fix disk problem
@deanjingshui deanjingshui force-pushed the p/deanjingshui/check-win branch from 9865b34 to 5a424dc Compare January 30, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant