fix: Support files configuration option#409
fix: Support files configuration option#409lambda47 wants to merge 2 commits intoweb-infra-dev:mainfrom
Conversation
👷 Deploy request for rslint pending review.Visit the deploys page to approve it
|
|
|
lambda47
force-pushed
the
fix/support_files_config
branch
2 times, most recently
from
5cd9799 to
1b1ad13
Compare
- optimize file matching logic - support negation glob patterns in `files` and `ignores` configurations
lambda47
force-pushed
the
fix/support_files_config
branch
from
1b1ad13 to
c3637ae
Compare
| if isFileIgnored(filePath, entry.Ignores) { | ||
| continue // Skip this config entry for ignored files | ||
| } | ||
| cwd, _ := os.Getwd() |
There was a problem hiding this comment.
If this fails, cwd becomes empty and pattern normalization may behave unexpectedly. Consider referring to the previous logic in isFileIgnoredSimple.
| LanguageOptions *LanguageOptions `json:"languageOptions,omitempty"` | ||
| Rules Rules `json:"rules"` | ||
| Plugins []string `json:"plugins,omitempty"` // List of plugin names | ||
| matcher *fileMatcher // Cache for the file matcher |
There was a problem hiding this comment.
The matcher field and GetFileMatcher method on ConfigEntry should be removed. Suggest creating matcher inline in GetRulesForFile instead.
| } | ||
|
|
||
| // classifyPatterns splits a list of glob patterns into its positive and negative patterns. | ||
| func classifyPatterns(patterns []string) (positivePatterns []string, negativePatterns []string) { |
There was a problem hiding this comment.
This separates patterns into two groups, which differs from how ignores handles negation (sequential "last match wins"). For example, ["src/**", "!**/*.test.ts", "**/important.test.ts"] would exclude important.test.ts because all negative patterns are applied after all positive patterns.
3 participants
Summary
Add support for
filesconfiguration optionfilesandignoresconfigurationsRelated Links
Fixed #408
Checklist