fix(android): decouple scalingRatio from size() method#2018
Open
fix(android): decouple scalingRatio from size() method#2018
Conversation
The scalingRatio was computed as a side effect inside size(). If a user overrode size() in a subclass, scalingRatio would remain at its default value of 1, causing adjustCoordinates() to produce incorrect physical coordinates. Extract the computation into a dedicated getScalingRatio() method that both size() and adjustCoordinates() call independently, so coordinate adjustment works correctly regardless of whether size() is overridden.
Deploying midscene with
|
| Latest commit: |
0c07ed0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cdeaa443.midscene.pages.dev |
| Branch Preview URL: | https://fix-android-scaling-ratio-in.midscene.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scalingRatiocalculation fromsize()into a dedicatedgetScalingRatio()method, soadjustCoordinates()computes the correct scaling ratio independently — even ifsize()is overridden by a subclass.size(), with overriddensize(), after DPR changes, and with customscreenshotResizeScale.Background
scalingRatiowas previously set as a side effect insidesize(). If a user overrode thesize()method (e.g., in a subclass),scalingRatiowould remain at its default value of1, causingadjustCoordinates()to produce incorrect physical coordinates for all touch/scroll operations.Changes
packages/android/src/device.ts:getScalingRatio()private method that lazily computes and caches the scaling ratiosize()now callsgetScalingRatio()instead of computing inlineadjustCoordinates()now callsgetScalingRatio()directly instead of reading the instance variablescalingRatioInitializedflag whendevicePixelRatiochanges ininitializeDevicePixelRatio()packages/android/tests/unit-test/page.test.ts:scalingRatio independent of size()test suite with 5 test casesTest plan
npx nx test @midscene/android -- tests/unit-test/page.test.ts -t "scalingRatio"— 5 tests passnpx nx build @midscene/android— builds successfully