Skip to content

fix(computer): abort execution on stop by checking destroyed in screenshotBase64 #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quanru merged 2 commits into from
Feb 14, 2026
Merged

fix(computer): abort execution on stop by checking destroyed in screenshotBase64 #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5c2246
fix(computer): check destroyed flag in screenshotBase64 to abort exec…
quanru Feb 14, 2026
ff1ca64
fix(playground): do not recreate agent on cancel to avoid health chec…
quanru Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/computer/src/device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,9 @@ Available Displays: ${displays.length > 0 ? displays.map((d) => d.name).join(',
}

async screenshotBase64(): Promise<string> {
if (this.destroyed) {
throw new Error('ComputerDevice has been destroyed');
}
debugDevice('Taking screenshot', { displayId: this.displayId });

try {
Expand Down
11 changes: 9 additions & 2 deletions packages/playground/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,15 @@ class PlaygroundServer {
console.warn('Failed to get execution data before cancel:', error);
}

// Recreate/destroy agent to cancel the current task
await this.recreateAgent();
// Destroy agent to cancel the current task
// No need to recreate here — /execute always creates a fresh agent before each run
try {
if (this.agent && typeof this.agent.destroy === 'function') {
await this.agent.destroy();
}
} catch (error) {
console.warn('Failed to destroy agent during cancel:', error);
}

// Clean up
delete this.taskExecutionDumps[requestId];
Expand Down