refactor(recorder): remove unused scroll handling logic and simplify event recording process#1740
Open
kun771447 wants to merge 2 commits intoweb-infra-dev:mainfrom
Open
Conversation
…event recording process
✅ Deploy Preview for midscene ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
你好，我是这个特性的作者。 如果没有这段mutationObserver，一些动态加载的可滚动元素，将不会被监听。 |
Contributor
|
噢……你把isElementScrollable的检测也给去掉了，所以即使去掉mutationObserver也能监听滚动。 |
… for click and scroll events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
参考 rrweb 简化滚动监听逻辑 https://github.com/rrweb-io/rrweb/blob/master/packages/rrweb/src/utils.ts#L23