Remove override for AuthDialog getInitialSize() to fix window size. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specified size for the AuthenticationDialog's getInitialSize() is too small on certain HiDPI displays. By removing the override, Eclipse decides an appropriate size based on the dialog content, ensuring that the user can see all components in the window.
Member
|
Thanks for the pull request. This problem is fixed in the separate dev event tracker branch, but hasn't yet been merged back into master. I'll check this change against what's already in that other branch to make sure they align properly. |
Author
|
Thanks. This is my first time using git or contributing to an open source project, so I appreciate your time and efforts. |
Member
|
No worries--we appreciate the contribution, and there's no way you'd know about what was going on in a separate experimental branch. I just want to make sure the two line up. This is definitely a bug that needs to be fixed in the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specified size for the AuthenticationDialog's getInitialSize() is too small on certain HiDPI displays. By removing the override, Eclipse decides an appropriate size based on the dialog content, ensuring that the user can see all components in the window. (This fixes a situation where, for myself and most of my students with newer laptops, none of the input fields for username/password were visible in the authentication dialog because the window was too small.)