fix: remove Composer cache from PHPStan job to ensure fresh dependencies#795
Merged
fix: remove Composer cache from PHPStan job to ensure fresh dependencies#795
Conversation
The CI workflow was using a Composer cache with restore-keys that could restore outdated dependencies from previous builds. This caused PHPStan to detect errors for missing generic types in Symfony Config classes, even though recent versions (8.0+) include these type annotations. Changes: - Remove Composer cache from phpstan job - phpstan now installs fresh dependencies on each run - Remove obsolete PHPStan baseline entries for Configuration generic types - These errors no longer appear with Symfony Config 8.0+ This ensures consistent PHPStan results between local and CI environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI workflow's PHPStan job was using a Composer cache with
restore-keysthat could restore outdated dependencies from any previous build. Sincecomposer.lockis not versioned in this repository, the cache key fell back tocomposer-Linux-, allowing very old dependency versions to be reused.This caused PHPStan to detect errors for missing generic type annotations in Symfony Config classes, even though recent versions (8.0+) include these annotations.
Solution
dependency-versions: higheston each runBenefits
Testing
The baseline cleanup was validated by running
castor phpstanlocally with Symfony Config 8.0.1, which no longer reports these generic type errors.Fixes the PHPStan failures on branches like #787 and the current 5.3.x baseline.