add missing std:: to shell_pair.hpp
#143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a compilation issue on gcc 14.2 by explicitly adding the std:: namespace to intmax_t, ensuring compatibility with Psi4's CI configuration.
- Fixes the compiler error regarding intmax_t by updating its namespace usage
- Ensures consistent type referencing in the csr_index function
wavefunction91
approved these changes
May 1, 2025
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the good work of #136.
Current
GauXCis killing Psi4's CI'sgcc 14.2lane due toerror: ‘intmax_t’ does not name a type; did you mean ‘int8_t’?. Let's give the compiler some help in finding this.