Skip to content

Stop recommending styled-components/macros #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
qnighy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stop recommending styled-components/macros #1104

qnighy wants to merge 2 commits into from
+4 −4

Conversation

@qnighy
Copy link
Contributor

@qnighy qnighy commented Nov 24, 2023

Why

styled-components/macros has been removed in v6.1: styled-components/styled-components#4064

What

Let's stop encouraging it; the Babel config would be just fine.

@github-actions github-actions bot added eslint-config-wantedly https://www.npmjs.com/package/eslint-config-wantedly repo Root directory of this project labels Nov 24, 2023
@github-actions github-actions bot added the eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript label Nov 24, 2023
@qnighy qnighy requested a review from s-kawabe November 24, 2023 08:50
s-kawabe
s-kawabe approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@s-kawabe s-kawabe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styled-components/macros has been removed in v6.1

I did not know!
will eslint-plugin-use-macros itself need to be removed in the near future?

Is this Pull Request meant to be a temporary response? 🤔

@s-kawabe
Copy link
Contributor

s-kawabe commented Nov 30, 2023

This plugin provides the rules to use the babel macros for specific libraries (such as styled-components and graphql-tag.)

Understood!
So this applies to more than just styled-components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-kawabe s-kawabe s-kawabe approved these changes

Assignees

No one assigned

Labels

eslint-config-wantedly https://www.npmjs.com/package/eslint-config-wantedly eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript repo Root directory of this project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qnighy @s-kawabe