block deserialization with dynafed support

[sekulicd]

This adds supports to deserialise dynafed block.

This closes #23

@tiero @asoltys please review.

[tiero]

add .idea to gitignore @sekulicd

[tiero]

Please run npm run prettier on your code to format correclty @sekulicd

[louisinger]

I would use the BufferReader from bufferutils.ts to read the bytes instead of read* functions.

[louisinger]

add .idea to gitignore @sekulicd

You also need to delete the folder and repush with "deleted .idea" in order to remove it from remote git repo

[tiero]

you need to check result is non null? @louisinger

[louisinger]

this checks if fromBuffer throws an error so LGTM. Best way to test is to check if all the block's fields are deserialized but may be hard to make the fixtures

[tiero]

I mean we need an it ro specify the test

ie.

Suggested change

	block.Block.fromBuffer(Buffer.from(f.hex, 'hex'));
	it('should de-serialize dyna-fed blcoks', () => {
	const bock = block.Block.fromBuffer(Buffer.from(f.hex, 'hex'));
	//assert block is non empty
	});

[asoltys]

I added another test fixture for a block with compact current and null proposed params taken from https://github.com/ElementsProject/rust-elements/blob/acc702c/src/block.rs#L653 and added assertions to check the expected block hash, version, and signBlockWitnessLimit, along with number of transactions.

The block hashes resulting from block.getHash() are not matching those expected by the tests in rust-elements. Any ideas why?

[tiero]

The block hashes resulting from block.getHash() are not matching those expected by the tests in rust-elements. Any ideas why?

cc/ @sekulicd

[sekulicd]

@asoltys seems that toBuffer func used to calculate Block hash is outdated.

[tiero]

thanks @asoltys

@sekulicd can you cherry-pick his commit to add the test? asoltys@4a0bb0c

[altafan]

@sekulicd @tiero @louisinger what's the status of this?

[tiero]

@sekulicd @tiero @louisinger what's the status of this?

Has been tested by @asoltys and confirmed was working, but we miss to clean it up, solve conflicts etc.. for proper merge in master branch

[sekulicd]

@tiero @altafan i merged with master and added code for block serialisation, please review commit a0edc38