Make coinbaseaux flags optional #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for solo mining on bitcoind, starting with v0.20.0 It's probably safe to delete the coinbase flags, but leave them in as optional for now. See also: bitcoin/bitcoin@9aedabe
Print name and id of the device that yielded the current best share.
|
Can we please merge this ? |
Allows for better tracking on a per-round basis.
* Optimized for solo mining * Add block height * Add last found block * Add best round share * Change best share to best share ever
cgminer only supports the P2PKH address format for the coinbase block creation. Using another address format will create malformed pubkey hashes. Maybe the support for P2SH or Bech32 formats will be added in the future.
Author
|
@jack1-software Your issue is not related to this PR at all, so please better create a seperate issue. |
|
Ok, I delete my issue. Thank you. |
This flag must be set explicitly now, since gcc 10+ uses -fno-common as default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for solo mining on bitcoind, starting with v0.20.0
It's probably safe to delete the coinbase flags, but leave them in as optional for now.
See also: bitcoin/bitcoin@9aedabe