Skip to content

Conversation

@yuxiaomao
Copy link
Contributor

@yuxiaomao yuxiaomao commented Aug 1, 2025

Manually update based on https://github.com/HaxeFoundation/haxe/blob/development/src-json/define.json and

  • Rename default to defaultValue
  • Removed DisplayDetails (as only used by vshaxe and is deprecated in haxe5)
  • Add more hl_ver
  • Fix C# target not displayed correctly in the description

Note:

  • If we're going to use Receive defines from haxe on server start #145 for all haxe >= 5, it can still provide fallback and invalid flags info (but it's less interesting because this need manual update)
  • Not sure if signatureNeutral / deprecatedDefine etc need to be included
  • The defines are unified to use - instead of _ in haxe's define.json, this has not impact on #if completion because vshaxe doesn't support it for the moment. However, if using display/defines request we still receive unified _.

@kLabz
Copy link
Contributor

kLabz commented Sep 29, 2025

Not sure if signatureNeutral / deprecatedDefine etc need to be included

  • signatureNeutral could be useful in some (niche) way as it's an indicator of whether a different cache should be used or not. I could at least see it being used by vshaxe itself in server view to display defines actually used to determine the signature, as I've had to do manually today for Fix duplicate context with haxe 5 #147

  • deprecatedDefine could also be used later I guess?

@kLabz
Copy link
Contributor

kLabz commented Nov 17, 2025

I think we can merge this? (regardless of #145 which I'll be testing)

@kLabz kLabz merged commit 94c4b86 into vshaxe:master Nov 17, 2025
6 checks passed
@yuxiaomao yuxiaomao deleted the dev-haxe-5-define branch November 18, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants