More tests for namespace redefined in element (take 2)#1316
Merged
w666 merged 4 commits intovpulim:masterfrom Jul 28, 2025
Merged
More tests for namespace redefined in element (take 2)#1316w666 merged 4 commits intovpulim:masterfrom
w666 merged 4 commits intovpulim:masterfrom
Conversation
This is within different elements. The provided WSDL was not serializing the response correctly when returning the XML. Created a request response folder to test the changes that were made and made sure code coverage remained the same. Author: lah8789 <[email protected]>
It turns out findNs() already covers this code and the code mods from vpulim#1151 are no longer necessary, but its test is useful and passes with current master.
smokhov
changed the title
w666
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1151
This PR rebases #1151 by @lah8789 and makes the tests pass.
After some testing of the code and getting its tests to pass, it turns out the proposed change was already covered in another PR that introduced
findNs(), so the code portion of 1151 PR was no longer necessary. This effectively reduces that PR just to the tests only; the more tests the better!Hopefully helps #1292