Conversation
Fails with `Exception has occurred: TypeError: Cannot read properties of undefined (reading 'description')` if Message>Body tags deepper inside answer.
smokhov
force-pushed
the
alex-eri-patch-1
branch
from
45fac4c to
f1abb47
Compare
See how this differs from local vs GitHub
|
Sigh... the timeouts seem to be related to GitHub runners' resources from my googling. Locally on my AlmaLinux 9.6 machine, all tests pass. So weird. I have to run the tests like this locally in order for the ssh1-rsa test to work: else it always fails. |
Done while testing an underlying PR's problem. OPENSSL_ENABLE_SHA1_SIGNATURES=1 is necessary where OpenSSL disables checks for older ciphers that one of the tests uses and fails the test, e.g. on EL9.
xmlns.soap in the original patch was always empty when checked; Its population occurred under the original if(), so move the populatio of xmlns attributes before the if(). Now all tests pass again.
|
I don't think this is related to node version. But I am getting timeouts in my environment too (WSL - Ubuntu 22.04 LTS, Node.js 22). I will try to have a look. |
|
I've found the reason. Will commit shortly. |
The tests use not only xmlsn.soap, but also .soapenv and .S, so they must be included for all the tests to reliably pass. Add some instrumentation.
|
I released urgent fix, it conflicts with your branch now. Sorry about that. |
|
@w666 TL;DR: after experimenting back and forth and adding some instrumentation it seems |
|
I think there should be an example request that triggers that original problem mentioned in the #1205. |
|
And I think I will ask to revert min node version related changes, but we can discuss it later. |
|
I suppose that #1284 can be related, there is code example. |
You are right, it may indeed be related! It does look relevant! I've added the reproduction content into the request-response samples al the wsdl and schemas, but having trouble getting the request working as it's giving me an error diff expecting something else vs. what's given in the SoapUI's samples in that issue. I'll commit a non-working test from that issue for further debugging for now so it doesn't sit just with me. Any comment is welcome @w666 as I don't have complete understanding of it yet. |
|
Thanks, I pulled the latest changes, maybe will have time this week. |
...st-response-samples/IndienenBericht__should_work_with_deeply_nested_XML_messages/request.xml
Show resolved
Hide resolved
Fix timeouts in test/request-response-samples-test.js when call back assertion fails, now it throws an error.
|
I think I fixed the test. Also fixed that annoying issue in test runner, it does not throw timeout error anymore |
w666
changed the title
|
Merged. Tried to clean up squashed commit message, hopefully I captured all the changes. Thank you @smokhov for leading this. |
3 participants
Closes #1205
Closes #1293
Closes #1284