re-arrange get_window_peak_arr for clarity and speed #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the call to `infer_desired_params` has been moved so that it only runs if thresholding is being performed. This removes unnecessary code execution; and no longer prints a message about inferred threshold parameters when thresholding is not being performed.
mwprestonjr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the call to
infer_desired_paramshas been moved so that it only runs if thresholding is being performed. This removes unnecessary code execution; and no longer prints a message about inferred threshold parameters when thresholding is not being performed.While this doesn't completely address the verbosity issue (#77), my code no longer floods the terminal which is nice.