Skip to content

Support serializion tensor scalar fns#7437

Merged
connortsui20 merged 2 commits intodevelopfrom
ct/tensor-scalar-plugin
Apr 15, 2026
Merged

Support serializion tensor scalar fns#7437
connortsui20 merged 2 commits intodevelopfrom
ct/tensor-scalar-plugin

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

Summary

Tracking issue: #7297

Adds serialization support to the tensor scalar fns. This is gated by the VORTEX_TENSOR_SCALAR_FN_ARRAY_PLUGINS environment variable.

Testing

Basic testing.

Unresolved Questions

  • I should probably write this to a file and roundtrip that, right?
  • It is also not clear if it makes sense to have a SorfTransformMetadata when it is basically identical to SorfOptions but with prost.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/feature A new feature label Apr 14, 2026
@connortsui20 connortsui20 changed the title Support serializin tensor scalar fns Support serializion tensor scalar fns Apr 14, 2026

static SESSION: LazyLock<VortexSession> =
LazyLock::new(|| VortexSession::empty().with::<ArraySession>());
static SESSION: LazyLock<VortexSession> = LazyLock::new(|| {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most crates put this in a mod tests { .. } in lib.rs, then share across all tests in the crate.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 enabled auto-merge (squash) April 15, 2026 01:38
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 15, 2026

Merging this PR will degrade performance by 23.16%

❌ 2 regressed benchmarks
✅ 1151 untouched benchmarks
⏩ 1455 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_10k_contiguous 269.7 µs 328 µs -17.77%
Simulation take_10k_random 192.9 µs 251.1 µs -23.16%

Comparing ct/tensor-scalar-plugin (38e7141) with develop (c4ad4e2)

Open in CodSpeed

Footnotes

  1. 1455 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20 connortsui20 merged commit 4a5b7d7 into develop Apr 15, 2026
57 of 58 checks passed
@connortsui20 connortsui20 deleted the ct/tensor-scalar-plugin branch April 15, 2026 01:43
@connortsui20
Copy link
Copy Markdown
Contributor Author

whoops I forgot to push my env variable changes, so technically anyone can write them now

@connortsui20
Copy link
Copy Markdown
Contributor Author

I have changes here but they require some stuff that isnt on develop yet: f37e388

Will figure this out tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants