This repository was archived by the owner on Jan 2, 2026. It is now read-only.
Build package only when required by configuration #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @SimplyDanny and thanks for your contribution! I'll have a deeper look on this soon. Could you replicate the same PR for the following extensions to keep them in sync? Thanks in advance. Feel free to @ me and assign me as reviewer if you can. :) |
Collaborator
Author
Sure. I can do that. Let's maybe first get this reviewed and merged. So I can replicate the accepted changes on the other two projects without much back and forth. |
|
Great job! I'm really looking forward to when this PR will be merged. |
Owner
|
Finally I found some time to prepare my environment and give your PR a try. Works perfectly! |
vknabel
approved these changes
Apr 11, 2025
This was referenced Apr 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever I open a workspace, the extension needs an unreasonable amount of time to build
swiftlintin release mode, blocking other activity on the Swift package from progressing.Taking the locally built binary is a nice feature, yet the overhead doesn't justify the benefit. Also, I found it quite surprising that the local version was preferred over the globally installed
swiftlintbinary even though I configuredswiftlint.pathspecifically.I think that restricting all this to
swiftlint.onlyEnableOnSwiftPMProjectsmakes sense. If you enable it now, the extension makes sure to build the package and restricts itself to the local binary ignoringswiftlint.path.This also resolves #99, I assume.