feat: Add preview page #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new preview page route and refactors the edit routing system to use file paths instead of content IDs. The changes enable direct navigation to a preview-only view and improve the mapping between files and their editor routes.
Key Changes:
- Added
/previewroute for accessing preview without an editor - Refactored edit routes from
/edit/$contentIdto/edit/$using file paths - Updated project setup logic to handle
entryContextconfiguration and properly map entry files
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/viola/src/stores/sandbox.ts | Added defaultDraftDir constant and config parsing on project load |
| packages/viola/src/stores/content.ts | Added getFileByFilename method to lookup content by filename |
| packages/viola/src/stores/actions/setup-project.ts | Refactored to use entryContext and file paths for content mapping |
| packages/viola/src/stores/actions/content-file.ts | Updated to use entryPath and defaultDraftDir for new content files |
| packages/viola/src/routes/(main)/_layout/preview.tsx | New preview-only route with tab setup |
| packages/viola/src/routes/(main)/_layout/edit/$contentId.tsx | Removed old content ID-based route |
| packages/viola/src/routes/(main)/_layout/edit/$.tsx | New file path-based edit route |
| packages/viola/src/routeTree.gen.ts | Generated routing tree updates for new route structure |
| packages/viola/src/components/side-menu.tsx | Added "Open Print Preview" menu item and updated file navigation links |
| packages/viola/src/components/panes/preview.tsx | Added await for setupPromise before rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.