Merged
Conversation
Contributor
|
I only have a very rough idea of how this stuff is meant to work, so can't really tell if it's correct just from looking at the code. But if it passes the IDE tests and you've tried it out and it seems to work then it's fine with me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to increase test reliability of Viper IDE.
We limit the number of AST jobs to three, but currently do not free up slots very well. For example, if you switch around between files somewhat quickly, then things will get stuck because the slots are not freed up. This "getting-stuck" means that the server stops responding, so tests fail.
This PR frees these slots more aggressively when things are cancelled (e.g. by switching to a different file while verification is still running) so that this hang-up doesn't happen anymore.