Simplify the delimited codeblock regex #405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex:
`{3,}`*
Means "three or more copies of a backtick, followed by zero or more
copies of a backtick." Similarly, the regex:
\~{3,}\~*
Is the same, but with the tilde character.
It looks like the original author of this regex might have misunderstood
the regex repetition operator, thinking that `{3,}` means "exactly three
copies," or possibly an earlier version of this regex might have
forcibly enabled Vim's support for non-greedy matches.
Regardless, the trailing `*` regex operator for matching zero or more
copies is redundant and can be removed. This might translate to a minor
performance improvement, but I have not attempted to measure that.
Contributor
Author
|
On pushing to CI, it looks like possibly this change was made to work around a bug in vint. Separately, it looks like vint is failing to run on Python 3.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex:
Means "three or more copies of a backtick, followed by zero or more
copies of a backtick." Similarly, the regex:
Is the same, but with the tilde character.
It looks like the original author of this regex might have misunderstood
the regex repetition operator, thinking that
{3,}means "exactly threecopies," or possibly an earlier version of this regex might have
forcibly enabled Vim's support for non-greedy matches.
Regardless, the trailing
*regex operator for matching zero or morecopies is redundant and can be removed. This might translate to a minor
performance improvement, but I have not attempted to measure that.