fix: Don't export the Detail type in gin-action source#2
Merged
lambdalisue merged 1 commit intovim-fall:mainfrom Jan 14, 2026
Merged
fix: Don't export the Detail type in gin-action source#2lambdalisue merged 1 commit intovim-fall:mainfrom
Detail type in gin-action source#2lambdalisue merged 1 commit intovim-fall:mainfrom
Conversation
It leads to a unwilling result where the gin-action source's `Detail` type appears at the toplevel of `@vim-fall/extra/source`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the current implementation, the
Detailtype of gin-action source is exported, but it leads to a unwilling result where the gin-action source'sDetailtype appears at the toplevel of@vim-fall/extra/source.This PR fixes it.
This should also fixes the publishing failure: https://github.com/vim-fall/deno-fall-extra/actions/runs/20981983827