fix(ci): Upgrade @denops/test and refactor CI config#293
Conversation
|
Warning Rate limit exceeded@lambdalisue has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 59 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughUpdated CI workflow to use Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diff --git a/deno.jsonc b/deno.jsonc
index 476dafd..0353732 100644
--- a/deno.jsonc
+++ b/deno.jsonc
@@ -48,7 +48,7 @@
"@core/asyncutil": "jsr:@core/asyncutil@^1.2.0",
"@core/unknownutil": "jsr:@core/unknownutil@^4.3.0",
"@denops/core": "jsr:@denops/core@^8.0.0",
- "@denops/test": "jsr:@denops/test@^3.1.0",
+ "@denops/test": "jsr:@denops/test@^3.0.0",
"@lambdalisue/errorutil": "jsr:@lambdalisue/errorutil@^1.1.1",
"@lambdalisue/itertools": "jsr:@lambdalisue/itertools@^1.1.2",
"@lambdalisue/unreachable": "jsr:@lambdalisue/unreachable@^1.0.1",fixes the error. Because |
So
The errors are reproduced. |
Because Deno currently has an issue for generating coverage reports on Windows, we want to run all tests even if one fails. denoland/deno#30924
|
CI failed with denoland/deno#30924. Ignore |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 64 64
Lines 2864 2864
Branches 278 277 -1
=======================================
Hits 2428 2428
Misses 434 434
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎯 Purpose
Fix CI failures caused by version incompatibility between @denops/core and @denops/test.
📝 Description
What Changed
denoland/setup-deno@v1.1.4todenoland/setup-deno@v2in the test job@denops/corefrom v8.0.0 back to v7.0.0Root Cause
The CI started failing after upgrading @denops/core from v7 to v8. The issue is that @denops/test v3.0.4 is hardcoded to use
@denops/core@^7.0.0, creating a version conflict when the project uses v8.This mismatch caused runtime errors that manifested as "TypeError: callback is not a function" in fs.close() when running tests in the Linux CI environment.
🔄 Type of Change
🧪 Testing
Root Cause Analysis
Expected Result
With @denops/core downgraded to v7, both the project and @denops/test will use the same version, eliminating the conflict.
✅ Checklist
Code Quality
Testing
🔗 Related Issues
Fixes CI failures that started from: c720851
📊 Impact
This temporarily downgrades @denops/core to v7 to maintain compatibility with @denops/test. When @denops/test is updated to support v8, the project can upgrade again.
📝 Next Steps
Summary by CodeRabbit