This repository was archived by the owner on Jan 30, 2026. It is now read-only.
Update sample_generator.py#266
Merged
victorchall merged 1 commit intovictorchall:mainfrom Dec 18, 2024
Merged
Conversation
Changed {sample_index} to {sample_index:03} in file names and logs for sample generator to allow for proper sorting in wandb and other places when there are more than 10 samples as currently wandb sorts as follows: 0, 1, 10, 11, 2, etc. With this change it would be 000, 001, 002, ... , 010, 011, etc.
Owner
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within utils/sample_generator.py, changed {sample_index} to {sample_index:03} where it writes file names and logs to allow for proper sorting in wandb and other places when there are more than 10 samples.
In the existing code samples are numbered 0, 1, 2, ..., 10, 11, etc which wandb and file systems sort as 0, 1, 10, 11, 2, etc. With this change it would be 000, 001, 002, ... , 010, 011, etc which would be sorted properly in all places.