Strengthen _rsc cache-busting param

[ztanner]

No description provided.

[ztanner]

• Strengthen _rsc cache-busting param #92755 👈 (View in Graphite)
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nextjs-bot]

Failing test suites

Commit: d0a321d | About building and testing Next.js

pnpm test test/integration/create-next-app/templates/app-api.test.ts (turbopack) (job)

• create-next-app --api (Headless App) > should create JavaScript project with --js flag (DD)
• create-next-app --api (Headless App) > should create TypeScript project with --ts flag (DD)
• create-next-app --api (Headless App) > should create project inside "src" directory with --src-dir flag (DD)

Expand output

● create-next-app --api (Headless App) › should create JavaScript project with --js flag

FetchError: request to http://localhost:34207/ failed, reason: connect ECONNREFUSED 127.0.0.1:34207

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7_encoding@0.1.13/node_modules/node-fetch/lib/index.js:1491:11)

● create-next-app --api (Headless App) › should create TypeScript project with --ts flag

FetchError: request to http://localhost:35349/ failed, reason: connect ECONNREFUSED 127.0.0.1:35349

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7_encoding@0.1.13/node_modules/node-fetch/lib/index.js:1491:11)

● create-next-app --api (Headless App) › should create project inside "src" directory with --src-dir flag

FetchError: request to http://localhost:38093/ failed, reason: connect ECONNREFUSED 127.0.0.1:38093

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7_encoding@0.1.13/node_modules/node-fetch/lib/index.js:1491:11)

pnpm test test/integration/create-next-app/package-manager/npm.test.ts (turbopack) (job)

• create-next-app with package manager npm > should use npm for --use-npm flag (DD)
• create-next-app with package manager npm > should use npm when user-agent is npm (DD)

Expand output

● create-next-app with package manager npm › should use npm for --use-npm flag

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  86 |   for (const file of files) {
  87 |     try {
> 88 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  89 |     } catch (err) {
  90 |       require('console').error(
  91 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:88:54)
  at integration/create-next-app/package-manager/npm.test.ts:50:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager/npm.test.ts:28:5)

● create-next-app with package manager npm › should use npm when user-agent is npm

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  86 |   for (const file of files) {
  87 |     try {
> 88 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  89 |     } catch (err) {
  90 |       require('console').error(
  91 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:88:54)
  at integration/create-next-app/package-manager/npm.test.ts:81:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager/npm.test.ts:59:5)

pnpm test-deploy test/e2e/app-dir/resume-data-cache/resume-data-cache.test.ts (job)

• resume-data-cache > should have consistent data between static and dynamic renders with use cache (DD)

Expand output

● resume-data-cache › should have consistent data between static and dynamic renders with use cache

expect(received).toContain(expected) // indexOf

Expected substring: "0.7099423091124076"
Received string:    "1:\"$Sreact.fragment\"
2:\"$Sreact.suspense\"
4:I[484,[],\"OutletBoundary\"]
6:[]
0:{\"buildId\":\"\",\"data\":[{\"rsc\":[\"$\",\"$1\",\"c\",{\"children\":[[[\"$\",\"p\",null,{\"id\":\"random-number\",\"children\":0.6135843744285377}],[\"$\",\"p\",null,{\"id\":\"another-random-number\",\"children\":\"0.6938314787197246\"}],[\"$\",\"$2\",null,{\"children\":\"$L3\"}]],null,[\"$\",\"$L4\",null,{\"children\":[\"$\",\"$2\",null,{\"name\":\"Next.MetadataOutlet\",\"children\":\"$@5\"}]}]]}],\"isPartial\":true,\"staleTime\":300,\"varyParams\":\"$W6\"}]}
5:null
"

  116 |           })
  117 |           .then((res) => res.text())
> 118 |         expect(rsc).toContain(random2)
      |                     ^
  119 |       })
  120 |
  121 |       // Then get the dynamic RSC again and validate that it also contains the

  at toContain (e2e/app-dir/resume-data-cache/resume-data-cache.test.ts:118:21)
  at retry (lib/next-test-utils.ts:862:14)
  at e2e/app-dir/resume-data-cache/resume-data-cache.test.ts:108:7