[slack] [bug] preserve self mentions in multi-workspace installs#328
Closed
mdnanocom wants to merge 1 commit intovercel:mainfrom
Closed
[slack] [bug] preserve self mentions in multi-workspace installs#328mdnanocom wants to merge 1 commit intovercel:mainfrom
mdnanocom wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
@mdnanocom is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In multi-workspace Slack installs, the adapter was only preserving self mentions with the adapter-level
_botUserId. For OAuth-installed workspaces, the active bot identity is request-scoped, so<@BOT_USER_ID>could be rewritten before mention detection ran.This change makes self-mention preservation use the effective request-scoped
botUserId, so plain Slackmessageevents still triggeronNewMention()correctly in multi-workspace installs.What changed
this.botUserIdinstead of only_botUserIdinresolveInlineMentions()messageevent with a bot self mentionthis.botUserIdalready falls back to_botUserIdwhen there is no request-scoped context, so single-workspace behavior stays the same.Note
The core bug affects plain Slack
messageevents that rely on fallback mention detection.app_mentionevents are already marked as mentions separately.