Add support for the ".lbm" extension; Prefer "LispBM" over "Lisp" #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the ".lbm" file extension, prefering it over the old ".lisp". Concretely, this commit adds support for ".lbm": - in all file dialogs - when creating lbm and vesc packages - when reducing lbm files - when packing LispBM imports. The LispBM file info dialog's text is updated to reflect this. It also adds preference for the ".lbm" extension in the "From VESC.lbm" filename and in some debug files' names.
Changes the extensions of the LispBM examples from ".lisp" to ".lbm". Also renames the containing folder to "LispBM" because it feels more consistent (and I'm renaming them all anyway).
Changes all places which refer to LispBM as "Lisp" to instead use the full capitalized form "LispBM" to be more precise. This aligns the UI with the change to prefer the ".lbm" extension over ".lisp". Also removes incorrectly hyphens in compound nouns which include "lisp". For example, "LispBM-scripts" is changed to "LispBM scripts". Additionally changes the Discord channel name referenced in pagelisp.cpp to match the name in the official Discord.
Owner
|
Nice work, thanks for this one! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the ".lbm" file extension, prefering it over the old ".lisp" as the latter is less precise.
It also changes all places which refer to LispBM as "Lisp" to instead use
the full capitalized form "LispBM". This aligns the UI with the above preference. This is of a slightly more opinionated change, so if you have any worries about it I can move it to a separate PR or remove it.
All identifiers in the codebase which refer to "lisp" are left as is.