fix: remove mail patches (gitextensions#12522)

Create patches had an option to mail patches directly.
This handling was not working with newer mail protocols and
certainly not web based email.
Also, the implementation would be completely broken with .net10.

The implementation was therefore removed.
The design of the form was slightly cleaned up as well.

Author: gerhardol

src/app/GitCommands/Settings/AppSettings.cs

@@ -992,24 +992,6 @@ public static GitPullAction FormPullAction
             set => SetEnum("FormPullAction", value);
         }
 
-        public static string SmtpServer
-        {
-            get => SettingsContainer.Detailed().SmtpServer;
-            set => SettingsContainer.Detailed().SmtpServer = value;
-        }
-
-        public static int SmtpPort
-        {
-            get => SettingsContainer.Detailed().SmtpPort;
-            set => SettingsContainer.Detailed().SmtpPort = value;
-        }
-
-        public static bool SmtpUseSsl
-        {
-            get => SettingsContainer.Detailed().SmtpUseSsl;
-            set => SettingsContainer.Detailed().SmtpUseSsl = value;
-        }
-
         public static bool AutoStash
         {
             get => GetBool("autostash", false);

src/app/GitCommands/Settings/DetailedSettings.cs

@@ -6,9 +6,6 @@ internal sealed class DetailedSettings : IDetailedSettings
     {
         private const string DetailedGroupName = "Detailed";
 
-        private const string SmtpServerDefault = "smtp.gmail.com";
-        private const int SmtpPortDefault = 465;
-        private const bool SmtpUseSslDefault = true;
         private const bool GetRemoteBranchesDirectlyFromRemoteDefault = false;
         private const bool AddMergeLogMessagesDefault = false;
         private const int MergeLogMessagesCountDefault = 20;
@@ -20,48 +17,6 @@ public DetailedSettings(SettingsSource settingsSource)
             _settingsSource = settingsSource;
         }
 
-        public string SmtpServer
-        {
-            get => _settingsSource.GetString(nameof(SmtpServer), SmtpServerDefault);
-            set
-            {
-                if (SmtpServer == value)
-                {
-                    return;
-                }
-
-                _settingsSource.SetString(nameof(SmtpServer), value);
-            }
-        }
-
-        public int SmtpPort
-        {
-            get => _settingsSource.GetInt(nameof(SmtpPort), SmtpPortDefault);
-            set
-            {
-                if (SmtpPort == value)
-                {
-                    return;
-                }
-
-                _settingsSource.SetInt(nameof(SmtpPort), value);
-            }
-        }
-
-        public bool SmtpUseSsl
-        {
-            get => _settingsSource.GetBool(nameof(SmtpUseSsl), SmtpUseSslDefault);
-            set
-            {
-                if (SmtpUseSsl == value)
-                {
-                    return;
-                }
-
-                _settingsSource.SetBool(nameof(SmtpUseSsl), value);
-            }
-        }
-
         public bool GetRemoteBranchesDirectlyFromRemote
         {
             get => _settingsSource.GetBool($"{DetailedGroupName}.{nameof(GetRemoteBranchesDirectlyFromRemote)}", GetRemoteBranchesDirectlyFromRemoteDefault);

src/app/GitExtensions.Extensibility/Settings/IDetailedSettings.cs

@@ -2,12 +2,6 @@
 
 public interface IDetailedSettings
 {
-    string SmtpServer { get; set; }
-
-    int SmtpPort { get; set; }
-
-    bool SmtpUseSsl { get; set; }
-
     bool GetRemoteBranchesDirectlyFromRemote { get; set; }
 
     bool AddMergeLogMessages { get; set; }