fix: prepare for .net10 (gitextensions#12519)

Fix obsolete code for .net10
Reenable some code analyzers disabled in .net9 update

Author: gerhardol

eng/GitExtensions.ruleset

@@ -10,7 +10,6 @@
     <Rule Id="VSTHRD110" Action="None" />
   </Rules>
   <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
-    <Rule Id="SA1010" Action="None" />
     <Rule Id="SA1101" Action="None" />
     <Rule Id="SA1116" Action="None" />
     <Rule Id="SA1117" Action="None" />

src/app/GitCommands/Remotes/AzureDevOpsRemoteParser.cs

@@ -17,7 +17,7 @@ public sealed partial class AzureDevOpsRemoteParser : RemoteParser
         [GeneratedRegex(@"^git@ssh\.dev\.azure\.com:v\d\/(?<owner>[^\/]*)\/(?<project>[^\/]*)\/(?<repo>.*)$")]
         private static partial Regex AzureDevopsSshRemoteRegex();
 
-        private static readonly Regex[] _azureDevopsRegexes = [ AzureDevopsHttpsRemoteRegex(), AzureDevopsSshRemoteRegex(), VstsHttpsRemoteRegex(), VstsSshRemoteRegex()];
+        private static readonly Regex[] _azureDevopsRegexes = [AzureDevopsHttpsRemoteRegex(), AzureDevopsSshRemoteRegex(), VstsHttpsRemoteRegex(), VstsSshRemoteRegex()];
 
         public bool IsValidRemoteUrl(string remoteUrl)
             => TryExtractAzureDevopsDataFromRemoteUrl(remoteUrl, out _, out _, out _);

src/app/GitUI/CommandsDialogs/FormBrowse.cs

@@ -576,6 +576,14 @@ protected override void OnDeactivate(EventArgs e)
 
         protected override void OnFormClosing(FormClosingEventArgs e)
         {
+            // Restore state at startup if file history mode, ignore the forced setting
+            if (_isFileHistoryMode)
+            {
+                MainSplitContainer.Panel1Collapsed = _fileBlameHistoryLeftPanelStartupState;
+            }
+
+            _splitterManager.SaveSplitters();
+
             SaveApplicationSettings();
 
             foreach (Control control in this.FindDescendants())
@@ -587,23 +595,11 @@ protected override void OnFormClosing(FormClosingEventArgs e)
             base.OnFormClosing(e);
         }
 
-        protected override void OnClosing(CancelEventArgs e)
-        {
-            // Restore state at startup if file history mode, ignore the forced setting
-            if (_isFileHistoryMode)
-            {
-                MainSplitContainer.Panel1Collapsed = _fileBlameHistoryLeftPanelStartupState;
-            }
-
-            _splitterManager.SaveSplitters();
-            base.OnClosing(e);
-        }
-
-        protected override void OnClosed(EventArgs e)
+        protected override void OnFormClosed(FormClosedEventArgs e)
         {
             PluginRegistry.Unregister(UICommands);
             RevisionGrid.CancelBackgroundTasks();
-            base.OnClosed(e);
+            base.OnFormClosed(e);
         }
 
         protected override void OnUICommandsChanged(GitUICommandsChangedEventArgs e)

src/app/GitUI/CommandsDialogs/FormSparseWorkingCopy.cs

@@ -25,7 +25,7 @@ private void BindSaveOnClose(FormSparseWorkingCopyViewModel sparse)
         {
             ArgumentNullException.ThrowIfNull(sparse);
 
-            Closing += (sender, args) =>
+            FormClosing += (sender, args) =>
             {
                 try
                 {

src/app/GitUI/CommandsDialogs/FormSubmodules.cs

@@ -41,10 +41,10 @@ protected override void OnLoad(EventArgs e)
             base.OnLoad(e);
         }
 
-        protected override void OnClosing(CancelEventArgs e)
+        protected override void OnFormClosing(FormClosingEventArgs e)
         {
             _splitterManager.SaveSplitters();
-            base.OnClosing(e);
+            base.OnFormClosing(e);
         }
 
         private void AddSubmoduleClick(object sender, EventArgs e)

src/app/GitUI/GitUI.csproj

@@ -7,8 +7,7 @@
     <Nullable>annotations</Nullable>
 
     <ForceDesignerDpiUnaware>true</ForceDesignerDpiUnaware>
-     <!-- Suppress suggestion to use experimental API ShowDialogAsync -->
-    <NoWarn>$(NoWarn);WFO5002</NoWarn>
+
     <!--
     For debug purposes uncomment these lines:
 

src/plugins/Bitbucket/BitbucketRequestBase.cs

@@ -25,13 +25,6 @@ protected BitbucketRequestBase(Settings settings)
 
         public async Task<BitbucketResponse<T>> SendAsync()
         {
-            if (Settings.DisableSSL)
-            {
-#pragma warning disable SYSLIB0014 // Type or member is obsolete
-                System.Net.ServicePointManager.ServerCertificateValidationCallback = delegate { return true; };
-#pragma warning restore SYSLIB0014 // Type or member is obsolete
-            }
-
             Validates.NotNull(Settings.BitbucketUrl);
             Validates.NotNull(Settings.Username);
             Validates.NotNull(Settings.Password);
@@ -41,6 +34,10 @@ public async Task<BitbucketResponse<T>> SendAsync()
                 BaseUrl = new Uri(Settings.BitbucketUrl),
                 Authenticator = new HttpBasicAuthenticator(Settings.Username, Settings.Password)
             };
+            if (Settings.DisableSSL)
+            {
+                client.RemoteCertificateValidationCallback = delegate { return true; };
+            }
 
             RestRequest request = new(ApiUrl, RequestMethod);
             if (RequestBody is not null)

src/plugins/BuildServerIntegration/TeamCityIntegration/TeamCityAdapter.cs

@@ -549,7 +549,7 @@ private Task<XDocument> GetProjectsResponseAsync(CancellationToken cancellationT
 
         private Task<XDocument> GetFilteredBuildsXmlResponseAsync(string buildTypeId, CancellationToken cancellationToken, DateTime? sinceDate = null, bool? running = null)
         {
-            List<string> values = [ "branch:(default:any)"];
+            List<string> values = ["branch:(default:any)"];
 
             if (sinceDate.HasValue)
             {

src/plugins/Statistics/GitImpact/FormImpact.cs

@@ -21,11 +21,11 @@ public FormImpact(IGitModule module)
             }
         }
 
-        protected override void OnClosed(EventArgs e)
+        protected override void OnFormClosed(FormClosedEventArgs e)
         {
             Impact.Stop();
 
-            base.OnClosed(e);
+            base.OnFormClosed(e);
 
             Impact.Dispose();
         }