Add the ability to specify paper size in mm #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you a lot for your contribution. I've made a few changes to the code. If you have no suggestions, I will publish a new release. |
Contributor
Author
Those changes look good to me 😄 |
vb64
added a commit
that referenced
this pull request
Sep 24, 2025
* Implement custom paper sizes (#73) * fix operand * paper_size as tuple * mm to py constant * fix doc * Move paper size code to Section class * cosmetic * add tests --------- Co-authored-by: Jake Charman <[email protected]>
Owner
Implemented in version 1.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, thanks for the great library 😄. I've been using it to generate PDFs of labels to be printed from a thermal label printer and as such needed to support some unusual paper sizes.
This PR adds the ability to specify a paper size in millimeters as a list
[width, height]whilst retaining the existing functionality to use predefined paper sizes.