fix(macos): fix can't open file by double click file in Finder and open -a in commandline #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en -a in commandline Changes: - Add decode_file_url() function using percent_encoding crate - Handle file:/// and file://localhost/ URL formats used by macOS - Add percent-encoding = "2.3" to Cargo.toml (explicit dependency) - Update Cargo.lock with percent-encoding dependency - Add error logging for file path validation failures This patch ensures proper decoding of URL-encoded file paths including UTF-8 multi-byte characters (e.g., Chinese filenames) when files are opened via `open -a markdown-viewer FILE.md` command. The percent_encoding crate is already included as a transitive dependency through Tauri, so this doesn't add a new dependency to the final binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en -a in commandline
Changes:
This patch ensures proper decoding of URL-encoded file paths including UTF-8 multi-byte characters (e.g., Chinese filenames) when files are opened via
open -a markdown-viewer FILE.mdcommand.The percent_encoding crate is already included as a transitive dependency through Tauri, so this doesn't add a new dependency to the final binary.