Fix/macos file association #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement proper macOS file opening via RunEvent::Opened event - Add OpenedFileState to store file paths from OS file associations - Add get_opened_file command to retrieve files opened via "Open With" - Handle both file:// URLs and direct file paths from macOS - Maintain fallback support for command line arguments on other platforms - Add dual event system (direct emission + state-based retrieval) - Include proper file path validation for security This fixes the issue where double-clicking markdown files on macOS would launch the app but not open the file. The solution uses Tauri's RunEvent::Opened which captures the NSApplication delegate events that macOS sends when files are opened via file associations.
- Test builds on Ubuntu, Windows, and macOS - Runs on pushes and pull requests - Validates no regressions across platforms
- Add 'fix/*' and 'feature/*' branch patterns to push triggers - Enables CI validation on feature branches before PR creation
…ation - Add #[cfg(any(target_os = "macos", target_os = "ios"))] to RunEvent::Opened handler - Fixes Windows/Linux build failure where RunEvent::Opened variant doesn't exist - Maintains cross-platform compatibility while enabling macOS file association fix
- Make RunEvent import conditional for macOS/iOS only - Prefix unused app_handle parameter with underscore - Ensures clean builds across all platforms
- Remove Ubuntu from test matrix to match production build.yml - Add fail-fast: false for better visibility of platform-specific issues - Aligns test workflow with actual release targets
- Upload Windows and macOS bundles as artifacts - 7-day retention for testing branch builds - Enables downloading and testing actual installers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.