Skip to content

Conversation

@vursen
Copy link
Contributor

@vursen vursen commented Jan 5, 2026

@vursen vursen force-pushed the grid-data-binding-page branch 22 times, most recently from 85abbb2 to 7b19232 Compare January 7, 2026 10:34
@vursen vursen marked this pull request as ready for review January 7, 2026 10:34
@vursen vursen requested review from rolfsmeds, sissbruecker and tomivirkki and removed request for rolfsmeds January 7, 2026 10:34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do we add another page that explains data provider / data view concepts when there is already one in the Flow docs with the same content? Why not improve the existing one?

Copy link
Contributor Author

@vursen vursen Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit hard to discover right now IMO. The new page doesn't aim to explain everything but to give a brief introduction specific to Grid and refer to the Flow documentation for more in-depth information.

I agree that at least "Custom Data Providers" would be better placed in the Flow documentation. And I could probably remove the setItems(fetchCallback, countCallback) example to keep things simpler.

Copy link
Contributor Author

@vursen vursen Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention was also to give complete, copy-pasteable Grid-specific examples that work right away.

Copy link
Contributor Author

@vursen vursen Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another goal was to make both Grid and Tree Grid have a Data Binding page so that their documentation structure is more consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, makes sense. Then I'd suggest to keep both the setItems examples and move the custom data provider example to the more in-depth Flow reference.

Copy link
Contributor Author

@vursen vursen Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved some of the content to the Flow reference, though I still think that a dedicated Grid data provider example is worth having on the Grid's Data Binding page at least for now. The Flow's Data Binding article is more focused on Spring usage and its examples aren't directly copy-pastable.

@vursen vursen removed the request for review from tomivirkki January 7, 2026 11:57
@vursen vursen force-pushed the grid-data-binding-page branch 2 times, most recently from 6f0bf23 to 099a195 Compare January 8, 2026 17:31
@vursen vursen force-pushed the grid-data-binding-page branch from 099a195 to e9f6e48 Compare January 8, 2026 17:36
@vursen vursen force-pushed the grid-data-binding-page branch from cdc5f9b to 4fcfa5b Compare January 12, 2026 09:22
@vursen vursen enabled auto-merge (squash) January 12, 2026 13:14
@vursen vursen merged commit 168cca2 into main Jan 12, 2026
3 checks passed
@vursen vursen deleted the grid-data-binding-page branch January 12, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants