-
Notifications
You must be signed in to change notification settings - Fork 216
docs: add Grid Data Binding page #5046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
85abbb2 to
7b19232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do we add another page that explains data provider / data view concepts when there is already one in the Flow docs with the same content? Why not improve the existing one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit hard to discover right now IMO. The new page doesn't aim to explain everything but to give a brief introduction specific to Grid and refer to the Flow documentation for more in-depth information.
I agree that at least "Custom Data Providers" would be better placed in the Flow documentation. And I could probably remove the setItems(fetchCallback, countCallback) example to keep things simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention was also to give complete, copy-pasteable Grid-specific examples that work right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another goal was to make both Grid and Tree Grid have a Data Binding page so that their documentation structure is more consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, makes sense. Then I'd suggest to keep both the setItems examples and move the custom data provider example to the more in-depth Flow reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved some of the content to the Flow reference, though I still think that a dedicated Grid data provider example is worth having on the Grid's Data Binding page at least for now. The Flow's Data Binding article is more focused on Spring usage and its examples aren't directly copy-pastable.
6f0bf23 to
099a195
Compare
099a195 to
e9f6e48
Compare
cdc5f9b to
4fcfa5b
Compare
Related to vaadin/flow-components#1886