cp: preserve destination context for recursive permission-denied errors#11084
Open
jorgitin02 wants to merge 1 commit intouutils:mainfrom
Open
cp: preserve destination context for recursive permission-denied errors#11084jorgitin02 wants to merge 1 commit intouutils:mainfrom
jorgitin02 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
sylvestre
reviewed
Feb 24, 2026
| match err { | ||
| CpError::IoErrContext(e, _) if e.kind() == io::ErrorKind::PermissionDenied => { | ||
| CpError::IoErrContext(e, _) | ||
| if e.kind() == io::ErrorKind::PermissionDenied |
Contributor
There was a problem hiding this comment.
it is starting to be a bit complex to understand, maybe move this into a function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9235.
Summary
Recursive
cpcurrently rewrites anyPermissionDeniedduring directory traversalas:
cannot open '<source>' for reading: permission deniedThat is incorrect when the failure is destination-side (for example, overwriting an
existing unwritable destination file).
This change preserves destination context for destination-side permission failures,
while keeping the source-read message for true source-read permission denial cases.
What changed
copydir: