date: Fix %x, %X, %r to respect locale settings#11068
Open
abendrothj wants to merge 1 commit intouutils:mainfrom
Open
date: Fix %x, %X, %r to respect locale settings#11068abendrothj wants to merge 1 commit intouutils:mainfrom
abendrothj wants to merge 1 commit intouutils:mainfrom
Conversation
Contributor
|
Please |
abendrothj
force-pushed
the
fix/dateformat
branch
2 times, most recently
from
462cb08 to
032b444
Compare
Contributor
Author
oops, forgot prehook doesnt work on mac currently |
abendrothj
force-pushed
the
fix/dateformat
branch
2 times, most recently
from
aa1ee97 to
0146bba
Compare
- Add locale.rs functions to query nl_langinfo for D_FMT, T_FMT, T_FMT_AMPM - Add expand_locale_specifiers() to replace %x, %X, %r with locale formats - Integrate locale specifier expansion before jiff formatting - Un-ignore and extend locale tests with graceful degradation
abendrothj
force-pushed
the
fix/dateformat
branch
from
0710de3 to
81b15f0
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Is it the expected behavior that the tests pass even without your changes to locale.rs and date.rs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10284
Previously these format specifiers were hardcoded to US/POSIX defaults, ignoring LC_TIME and LC_ALL. Now they call nl_langinfo to get the locale's actual format strings.
Changes:
now for ci...