Skip to content

use zip for cleaner iteration with 1-based index#10963

Open
xtqqczze wants to merge 2 commits intouutils:mainfrom
xtqqczze:use-zip
Open

use zip for cleaner iteration with 1-based index#10963
xtqqczze wants to merge 2 commits intouutils:mainfrom
xtqqczze:use-zip

Conversation

@xtqqczze
Copy link
Contributor

No description provided.

@sylvestre
Copy link
Contributor

if you cherry-pick my changes, please keep the author ...

@github-actions
Copy link

GNU testsuite comparison:

Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@xtqqczze
Copy link
Contributor Author

if you cherry-pick my changes, please keep the author ...

I may be mistaken, but I don’t believe this would be considered a cherry-pick, since it also includes additional changes to dircolors. I also didn’t think there were any attribution concerns, as I had originally made the suggestion in the referenced discussion (#10647 (comment)).

@sylvestre
Copy link
Contributor

still disagree ...

@xtqqczze
Copy link
Contributor Author

rebased to cherry-pick from #10647 (comment)

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/date/resolution. tests/date/resolution is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/head/head-write-error. tests/head/head-write-error is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants