use zip for cleaner iteration with 1-based index#10963
Open
xtqqczze wants to merge 2 commits intouutils:mainfrom
Open
use zip for cleaner iteration with 1-based index#10963xtqqczze wants to merge 2 commits intouutils:mainfrom
xtqqczze wants to merge 2 commits intouutils:mainfrom
Conversation
Contributor
|
if you cherry-pick my changes, please keep the author ... |
|
GNU testsuite comparison: |
Contributor
Author
I may be mistaken, but I don’t believe this would be considered a cherry-pick, since it also includes additional changes to dircolors. I also didn’t think there were any attribution concerns, as I had originally made the suggestion in the referenced discussion (#10647 (comment)). |
Contributor
|
still disagree ... |
Contributor
Author
|
rebased to cherry-pick from #10647 (comment) |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.