tac: support non-UTF-8 separator#10934
Open
victor-prokhorov wants to merge 1 commit intouutils:mainfrom
Open
Conversation
Collaborator
|
The ultimate goal it to get the non utf-8 stuff to be fully matching how gnu handles it, can you try to handle it in the same pr? |
6b18317 to
9bfe761
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
Collaborator
|
By fixing this it should also fix the tac-locale test so you can use that to guide you on whether the fix is working properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9502
open question: GNU tac also accepts non-UTF-8 separators in regex mode. right now, in this pr i return an error. should i handle this in the same PR, or i should do it in another?