-
Notifications
You must be signed in to change notification settings - Fork 107
fix(pack): add node_modules to watch ignore options #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在通过在文件监听配置中默认忽略 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
这个 PR 通过添加一个选项来在文件监听时忽略指定路径,从而提高了性能,默认忽略 node_modules。这与 Webpack 的行为类似,是一个很好的改进。代码在 API、N-API 和 schema 层的修改看起来是正确的。我有一个关于移除重复的默认值以提高代码可维护性的建议。
ff29f54 to
6b76355
Compare
* fix(pack): add node_modules to watch ignore options * chore: update review * chore: update napi files
Summary
在 linux gun 场景里面使用 devServer 的时候监听
node_modules里面的文件变更会有比较大的性能损失。目前 webpack 默认不监听 node_modules 中的依赖文件变更。
ref: utooland/next.js#97
Test Plan