Conversation
betsyecastro
changed the title
… in API index endpoint
The previous query scope was not properly accounting for the case where `show_not_accepting_students` was selected without `not_accepting_students`, due to how orWhereJsonDoesntContain works.
Collaborator
|
Just for future reference on commit 963f8f8, SQL 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
not-accepting-undergradparam to the search in the API index endpoint to only include the names of faculty members that are not marked as "Not accepting undergrad students" or that have not selected the option "Show not accepting students" on their profile page.Issue #155