Skip to content

Conversation

@a-detiste
Copy link
Contributor

Dear Maintainer,

mock has now been merged in the standard library a long time ago,
please consider removing this old external dependency


https://github.com/testing-cabal/mock

mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards.

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (886cb62) to head (de8309d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           99        99           
  Branches        25        25           
=========================================
  Hits            99        99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@utapyngo utapyngo requested a review from Copilot April 16, 2025 06:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the usage of the external "mock" module, switching to the standard library's unittest.mock in tests and updating workflow dependencies accordingly.

  • Removed the outdated import of "mock" in tests/test_unordered.py and replaced it with "unittest.mock".
  • Updated the GitHub Actions workflows to eliminate installation of the external mock dependency.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
tests/test_unordered.py Removed external mock import and replaced with unittest.mock
.github/workflows/test.yml Removed dependency installation of mock/types-mock from workflows
Files not reviewed (1)
  • tox.ini: Language not supported

@utapyngo utapyngo merged commit 6a83767 into utapyngo:master Apr 16, 2025
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants