Skip to content

Conversation

@ariutta
Copy link

@ariutta ariutta commented Jul 25, 2016

All tests pass.

Only things I noticed: in Chrome, the "request ended" message sometimes shows twice, with the first time coming before the final chunk. In FF, there seems to be a delay between the second and the final chunks.

There are also several TODOs in the code, and I made what I thought were some corrections, but it would be best if you could check my changes to be sure.

@ariutta
Copy link
Author

ariutta commented Jul 26, 2016

Would be good to verify that requests.destroy() does what's expected with this change.

@coveralls
Copy link

coveralls commented Jul 26, 2016

Coverage Status

Coverage remained the same at 42.857% when pulling 49d2a24 on ariutta:master into 87d2fa1 on unshiftio:master.

@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage remained the same at 42.857% when pulling f82feae on ariutta:master into 87d2fa1 on unshiftio:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants