Skip to content

fix(textblock): fix invalidation when font fallback asynchronously gets a new font#22644

Merged
ramezgerges merged 1 commit intounoplatform:masterfrom
ramezgerges:font_fallback_text_invalidation
Feb 13, 2026
Merged

fix(textblock): fix invalidation when font fallback asynchronously gets a new font#22644
ramezgerges merged 1 commit intounoplatform:masterfrom
ramezgerges:font_fallback_text_invalidation

Conversation

@ramezgerges
Copy link
Contributor

GitHub Issue: closes #22625

PR Type:

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Please check if your PR fulfills the following requirements:

Other information ℹ️

Copilot AI review requested due to automatic review settings February 12, 2026 19:46
@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Feb 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a Skia TextBlock rendering issue where asynchronous font fallback resolution doesn’t trigger the necessary layout invalidation, leaving displayed glyphs stale until another UI interaction forces a refresh.

Changes:

  • Update TextBlock’s UnicodeText.IFontCacheUpdateListener.Invalidate() to call InvalidateMeasure() so layout (and text shaping) is recomputed when fallback fonts become available.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ramezgerges
Copy link
Contributor Author

There's supposed to already be a runtime test ("Check_FontFallback_Shaping2") for this but for some reason it's passing in CI before the fix. Locally, it (correctly) fails.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22644/wasm-skia-net9/index.html

@ramezgerges ramezgerges merged commit f923ed4 into unoplatform:master Feb 13, 2026
52 of 53 checks passed
@ramezgerges ramezgerges deleted the font_fallback_text_invalidation branch February 13, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/skia ✏️ Categorizes an issue or PR as relevant to Skia

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font fallback doesn't invalidate the associated TextBlock(s)

3 participants