fix(textblock): fix invalidation when font fallback asynchronously gets a new font#22644
Merged
ramezgerges merged 1 commit intounoplatform:masterfrom Feb 13, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Skia TextBlock rendering issue where asynchronous font fallback resolution doesn’t trigger the necessary layout invalidation, leaving displayed glyphs stale until another UI interaction forces a refresh.
Changes:
- Update
TextBlock’sUnicodeText.IFontCacheUpdateListener.Invalidate()to callInvalidateMeasure()so layout (and text shaping) is recomputed when fallback fonts become available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
There's supposed to already be a runtime test ("Check_FontFallback_Shaping2") for this but for some reason it's passing in CI before the fix. Locally, it (correctly) fails. |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22644/wasm-skia-net9/index.html |
ajpinedam
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes #22625
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️