fix(macOS): external trackpad handle by ajpinedam · Pull Request #22629 · unoplatform/uno

ajpinedam · 2026-02-11T05:15:38Z

GitHub Issue: closes #

PR Type:

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Please check if your PR fulfills the following requirements:

📝 Commits must be following the Conventional Commits specification.
🧪 Added Runtime tests, UI tests, or a manual test sample for the changes have been added (for bug fixes / features) (if applicable)
📚 Docs have been added/updated which fit documentation template (for bug fixes / features)
🖼️ Validated PR Screenshots Compare Test Run results.
❗ Contains NO breaking changes

Other information ℹ️

Copilot

Pull request overview

Adjusts macOS (Skia) mouse button state reporting to better handle macOS 15+ external trackpads where NSEvent.pressedMouseButtons can be incorrect, by incorporating Quartz button state into the decision logic.

Changes:

Always compute a Quartz (CoreGraphics) mouse-button mask and use it to decide when to reset tracked button state.
Change reset behavior to only clear tracked state when both AppKit and Quartz report no pressed buttons.
When there is no tracked state, return AppKit’s mask if non-zero, otherwise fall back to Quartz.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/MouseButtons.m

unodevops · 2026-02-11T05:35:29Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22629/wasm-skia-net9/index.html

unodevops · 2026-02-11T06:28:32Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22629/wasm-skia-net9/index.html

unodevops · 2026-02-11T08:01:21Z

⚠️⚠️ The build 195779 has failed on Uno.UI - CI.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOWindow.m

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/MouseButtons.m

unodevops · 2026-02-13T17:07:23Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22629/wasm-skia-net9/index.html

unodevops · 2026-02-13T17:55:50Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22629/wasm-skia-net9/index.html

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/SamplesApp/UITests.Shared/UITests.Shared.projitems

...plesApp/UITests.Shared/Microsoft_UI_Xaml_Controls/WebView2Tests/WebView2_MouseEvents.xaml.cs

src/SamplesApp/LinkedFiles/WebContent/js/site.js

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/MouseButtons.h

unodevops · 2026-02-13T18:22:26Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22629/wasm-skia-net9/index.html

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...plesApp/UITests.Shared/Microsoft_UI_Xaml_Controls/WebView2Tests/WebView2_MouseEvents.xaml.cs

unodevops · 2026-02-13T19:14:16Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22629/wasm-skia-net9/index.html

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOWindow.m

...plesApp/UITests.Shared/Microsoft_UI_Xaml_Controls/WebView2Tests/WebView2_MouseEvents.xaml.cs

Copilot · 2026-02-13T21:17:18Z

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOWindow.m

+                // We trust AppKit and reset our counters.
+                if (mask != 0 && ((uint32)NSEvent.pressedMouseButtons) == 0) {
+                    mask = [MouseButtons buttonMask:event];


The logic here has a potential issue. When mask != 0 && NSEvent.pressedMouseButtons == 0, this code calls buttonMask:event which resets ALL button depths to 0 and then tracks only the current event. However, if the current event is not a mouse button event (e.g., it's a mouse move event), tracking it won't restore any button state, and the mask will return 0. This is correct if we genuinely missed a MouseUp. But if NSEvent.pressedMouseButtons is simply unreliable (as the FIXME comment suggests for Sequoia with external trackpads), this reset could incorrectly clear valid button state during non-button events. Consider whether the reset should only happen for specific event types or if there's a better way to handle the Sequoia trackpad inconsistency.

Suggested change

// We trust AppKit and reset our counters.

if (mask != 0 && ((uint32)NSEvent.pressedMouseButtons) == 0) {

mask = [MouseButtons buttonMask:event];

// We trust AppKit and reset our counters, but only when handling a mouse button event.

if (mask != 0 && ((uint32)NSEvent.pressedMouseButtons) == 0) {

NSEventType type = event.type;

BOOL isMouseButtonEvent =

type == NSEventTypeLeftMouseDown ||

type == NSEventTypeLeftMouseUp ||

type == NSEventTypeRightMouseDown ||

type == NSEventTypeRightMouseUp ||

type == NSEventTypeOtherMouseDown ||

type == NSEventTypeOtherMouseUp ||

type == NSEventTypeLeftMouseDragged ||

type == NSEventTypeRightMouseDragged||

type == NSEventTypeOtherMouseDragged;

if (isMouseButtonEvent) {

mask = [MouseButtons buttonMask:event];

}

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/MouseButtons.m

src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOWindow.m

unodevops · 2026-02-13T21:32:08Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22629/wasm-skia-net9/index.html

unodevops · 2026-02-14T02:51:12Z

⚠️⚠️ The build 196301 has failed on Uno.UI - CI.

ajpinedam self-assigned this Feb 11, 2026

Copilot AI review requested due to automatic review settings February 11, 2026 05:15

github-actions bot added the platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform label Feb 11, 2026

Copilot started reviewing on behalf of ajpinedam February 11, 2026 05:16 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

fix(macOS): external trackpad handle

5825a18

ajpinedam force-pushed the fix/macOS.external.trackpad.handle branch from 2e18cda to 5825a18 Compare February 11, 2026 06:09

fix(macOS): external trackpad events

00febe2

Copilot AI review requested due to automatic review settings February 13, 2026 16:48

Copilot started reviewing on behalf of ajpinedam February 13, 2026 16:48 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

test: manual test for trackpad events when using webview2

a960a5a

github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Feb 13, 2026

chore: apply code suggestion

7f12c9c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 13, 2026 18:03

Copilot started reviewing on behalf of ajpinedam February 13, 2026 18:04 View session

chore: remove reset method

1384233

Copilot AI reviewed Feb 13, 2026

View reviewed changes

chore: apply suggestions from code review

d42a73a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 13, 2026 18:52

Copilot AI reviewed Feb 13, 2026

View reviewed changes

...plesApp/UITests.Shared/Microsoft_UI_Xaml_Controls/WebView2Tests/WebView2_MouseEvents.xaml.cs Show resolved Hide resolved

Copilot started reviewing on behalf of ajpinedam February 13, 2026 19:06 View session

chore: remove un needed validation

59bfc59

ajpinedam marked this pull request as ready for review February 13, 2026 21:12

ajpinedam requested review from Copilot and morning4coffe-dev February 13, 2026 21:12

Copilot started reviewing on behalf of ajpinedam February 13, 2026 21:13 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

-                // We trust AppKit and reset our counters.
-                if (mask != 0 && ((uint32)NSEvent.pressedMouseButtons) == 0) {
-                    mask = [MouseButtons buttonMask:event];
+                // We trust AppKit and reset our counters, but only when handling a mouse button event.
+                if (mask != 0 && ((uint32)NSEvent.pressedMouseButtons) == 0) {
+                    NSEventType type = event.type;
+                    BOOL isMouseButtonEvent =
+                        type == NSEventTypeLeftMouseDown    ||
+                        type == NSEventTypeLeftMouseUp      ||
+                        type == NSEventTypeRightMouseDown   ||
+                        type == NSEventTypeRightMouseUp     ||
+                        type == NSEventTypeOtherMouseDown   ||
+                        type == NSEventTypeOtherMouseUp     ||
+                        type == NSEventTypeLeftMouseDragged ||
+                        type == NSEventTypeRightMouseDragged||
+                        type == NSEventTypeOtherMouseDragged;
+                    if (isMouseButtonEvent) {
+                        mask = [MouseButtons buttonMask:event];
+                    }

Conversation

ajpinedam commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type:

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Other information ℹ️

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

unodevops commented Feb 11, 2026

Uh oh!

unodevops commented Feb 11, 2026

Uh oh!

unodevops commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

unodevops commented Feb 13, 2026

Uh oh!

unodevops commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

unodevops commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

unodevops commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

unodevops commented Feb 13, 2026

Uh oh!

unodevops commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ajpinedam commented Feb 11, 2026 •

edited

Loading