-
-
Notifications
You must be signed in to change notification settings - Fork 371
feature/1078: Added Support For List, Dict, And Tuples Of Dataframes #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 137 137
Lines 10715 10757 +42
=======================================
+ Hits 8975 9011 +36
- Misses 1740 1746 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Gareth Ellis <[email protected]> Signed-off-by: Gareth Ellis <[email protected]>
9e83cfb to
6adbd70
Compare
|
Hey @cosmicBboy - would you mind giving this a cursory review? Happy to resolve the code coverage issue, but just want to make sure the overall structure is OK first. |
|
This is awesome! taking a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful @garethellis0 ! Would you mind updating the docs with some examples of this enhancement? (You can copy-paste or adapt the unit tests).
It can probably go into this page: https://github.com/unionai-oss/pandera/blob/main/docs/source/decorators.md#decorate-functions-and-coroutines
|
@cosmicBboy no problem, added! |
Signed-off-by: Gareth Ellis <[email protected]>
9dc3135 to
8ac431a
Compare
Signed-off-by: Gareth Ellis <[email protected]>
8ac431a to
e3598b6
Compare
|
@garethellis0 the docs build failure doesn't seem to be related to changes in this PR, it pops up even in |
|
will merge this now and handle the docs build issue separately |
|
Thanks @cosmicBboy - pleasure working with ya :) |
|
Any idea when the next release this will be included in will make it out? |
Supports nested types, as per the discussion in #1078