allowing projects to be archived #455
Conversation
| <p> | ||
| Are you sure you want to archive project <strong>{project?.name}</strong>? | ||
| </p> | ||
| <p>Archiving this project will:</p> | ||
| <ul> | ||
| <li> | ||
| Make the project <strong>read-only</strong> - no further edits will be allowed | ||
| </li> | ||
| <li>Keep all project data and configuration intact</li> | ||
| <li>Remove it from active project lists (but it will still be visible at the bottom)</li> | ||
| <li>Require administrator approval to unarchive in the future</li> | ||
| </ul> | ||
| <p> | ||
| <strong>Note:</strong> This is different from deleting - archived projects can be restored later if | ||
| needed. | ||
| </p> |
There was a problem hiding this comment.
Open to suggestions on wording here.
There was a problem hiding this comment.
also mention as the IAO only they will be able to see it and request un-archival; it won't appear to project members or admins whilst in read-only
There was a problem hiding this comment.
Hmm, so study admins do receive the studyOwner role, that's how they are given access to see projects and studies they belong to. Implementation-wise I think it would be easiest to leave this how it currently works, unless there is a problem with study admins seeing an archived project?
There was a problem hiding this comment.
will check with DSH but hopefully no qualms from them 🤞
|
currently the TRE doesn't support an archive state for a project, so not sure about this. cc: @gsvarovsky @finleybacon |
Ok, do we need to update the acceptance criteria for #11 ? Is archiving only for certain types of projects e.g. DSH? |
do you just delete them? I thought it was an IG req that they be retained but read-only for IAOs |
|
discussed with @gsvarovsky sync and: currently there is not an archive state for a TRE project: it's deployed or deleted. maybe in future there's a nice way of archiving a project's data, but not in near term. potentially other services have projects with an archive state |
@jhughes982 yes DSH projects can be archived, that's why this has snuck in. so worth keeping but need to make the button an environment specific thing in the manage project page, to only render for DSH projects |
api.web.yaml
Outdated
| - Pending | ||
| - Approved | ||
| - Rejected | ||
| - Archived |
There was a problem hiding this comment.
imo Archived doesn't make sense for an ApprovalStatus. I would have environment-specific project statuses (as the meaning is environment specific and there will be some statuses that are available for some environments but not others)
There was a problem hiding this comment.
Yeah, we did consider this in an earlier discussion. Happy to implement as you suggested 👍
There was a problem hiding this comment.
sorry – should have commented earlier
|
I have now removed some of the archive implementations based on @t-young31 's feedback:
The issue now is that we are implementing details (i.e. archiving) for a feature that hasn't been fully scoped yet (i.e. the I have added some placeholder code for now, but am unsure how best to proceed. Any thoughts @acholyn ? |
| - Archived | ||
| description: Current approval status (used for studies, projects, etc.) | ||
|
|
||
| ProjectStatus: |
There was a problem hiding this comment.
I was thinking ProjectDshStatus and ProjectTreStatus etc.
|
Setting this to draft for now until we are agreed on the DSH project requirements and have the ability to create DSH projects. |
4 participants
Works towards #11
This PR adds the ability to archive a project
Archive button:
Checklist