Conversation
|
📝 WalkthroughWalkthroughThe changes refactor the shared-ui package's CSS export strategy by renaming the public export from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🌏 Preview Deployments
Built from commit: 🤖 This comment will be updated automatically when you push new commits to this PR. |
There was a problem hiding this comment.
Pull request overview
This PR updates the shared UI package’s style export and import paths so that consumers import a stable styles.css entry built into dist, and broadens the globals CSS source scanning to include built JS/JSX files.
Changes:
- Update TypeScript path mapping and app-level CSS import to use
@ucdjs-internal/shared-ui/styles.cssinstead of the deeperstyles/globals.csspath. - Adjust the shared-ui package exports and tsdown build config so
./styles.csspoints to./dist/styles/globals.css, and copy the CSS intodist/stylesat build time. - Broaden the Tailwind
@sourceglob inglobals.cssto scants,tsx,mjs,js,jsxfiles undersrc/ui.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tooling/tsconfig/base.json | Updates the path alias to expose shared-ui styles as @ucdjs-internal/shared-ui/styles.css while still resolving to the source globals.css for local development. |
| packages/shared-ui/tsdown.config.ts | Ensures the build copies src/styles/globals.css into dist/styles and exports it as ./styles.css from the package. |
| packages/shared-ui/src/styles/globals.css | Expands the Tailwind @source glob so styles are generated from both source and built UI files (TS/JS/JSX/MJS). |
| packages/shared-ui/package.json | Changes the public export from ./styles/globals.css (source) to ./styles.css (built dist CSS) and aligns the files included in the package. |
| apps/web/src/globals.css | Updates the app to import styles from the new @ucdjs-internal/shared-ui/styles.css entrypoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
📚 Description
Summary by CodeRabbit