refactor: update schemas and fix some issues #437
Conversation
- Renamed `BaseItemSchema` to `FileEntryBaseSchema` for clarity. - Updated `FileEntrySchema` tests to use `toMatchSchema` for better readability. - Added tests for `FileEntryListSchema` and `UCDStoreManifestSchema` to enhance coverage. - Improved validation logic for expected files in the manifest schema.
|
📝 WalkthroughWalkthroughThis PR refactors the file-tree type system throughout the codebase, renaming Changes
Sequence Diagram(s)File-tree retrieval and validation flow with the new schema structure: sequenceDiagram
participant Client as Client/API
participant Route as GET /{version}/file-tree
participant Schema as UnicodeFileTreeSchema
participant Registry as Schema Registry
Client->>Route: Request file-tree
Route->>Route: Fetch and calculate file-tree
Route->>Route: Cast to UnicodeFileTree type
Route->>Schema: Validate against UnicodeFileTreeSchema
Schema->>Schema: Validate each UnicodeFileTreeNode<br/>(recursive directory/file structure)
Schema->>Registry: Register UnicodeFileTreeNode schema
Registry-->>Route: Schema registration confirmed
Schema-->>Route: Validation result (success)
Route-->>Client: JSON response with<br/>normalized lastModified (number)
Version details retrieval with mandatory statistics: sequenceDiagram
participant Client as Client
participant Route as GET /{version}
participant Stats as Statistics<br/>Calculation
participant Schema as UnicodeVersionDetailsSchema
Client->>Route: Request version details
Route->>Stats: calculateStatistics() or use tmp
Stats-->>Route: stats object
Route->>Route: Initialize statistics with defaults<br/>(newBlocks, totalBlocks, etc.)
Route->>Schema: Validate UnicodeVersionDetails<br/>including statistics
Schema-->>Route: Validation (statistics always object)
Route-->>Client: JSON with mandatory<br/>statistics object
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
the
pkg: schemas
🌏 Preview Deployments
Built from commit: 🤖 This comment will be updated automatically when you push new commits to this PR. |
📋 OpenAPI Schema AnalysisSummarySchema Components
Overall Status
Detailed Changes📋 Schema Components ChangesAdded Schemas (3):
Removed Schemas (2):
Modified Schemas (2):
Important This PR contains breaking changes that require maintainer approval. 🤖 This comment is automatically updated when you push new commits. |
Introduce `findFileByPath` and `flattenFilePaths` functions to enhance file tree manipulation capabilities. The new functions allow for recursive searching of files by path and flattening of hierarchical file structures into an array of paths. Additionally, remove the old `flatten` implementation to streamline the codebase.
Removed the hardcoded `baseUrl` and replaced it with `UCDJS_API_BASE_URL` for consistency across the version tests. Added `lastModified` timestamps to file entries in the mock file tree for better accuracy in testing.
luxass
changed the title
github-actions
bot
added
pkg: ucd-store
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR refactors schema naming conventions and fixes related type issues. The main changes involve renaming UnicodeTree* schemas to UnicodeFileTree* for better clarity and consistency, updating dependencies (zod 4.2.1 → 4.3.5, apache-autoindex-parse 4.1.0 → 5.0.2), and reorganizing shared utilities for file tree operations.
Key Changes:
- Renamed schema types from
UnicodeTree*toUnicodeFileTree*throughout the codebase - Consolidated file tree utilities (
flattenFilePaths,findFileByPath) into a singlefiles.tsmodule in the shared package - Updated
lastModifiedfield to usenumber | nullinstead of optionalnumber | undefinedfor consistency - Added comprehensive test coverage for the new schema structures
Reviewed changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updated zod to 4.3.5 and apache-autoindex-parse to 5.0.2 |
| pnpm-lock.yaml | Lockfile updates for dependency version changes |
| vscode/src/lib/files.ts | Updated import from UnicodeTreeNode to UnicodeFileTreeNodeWithoutLastModified |
| packages/utils/src/index.ts | Removed TreeEntry export as it's no longer used |
| packages/ucd-store/test/ | Updated type imports to use new UnicodeFileTree* naming |
| packages/ucd-store/src/store.ts | Updated return type to UnicodeFileTreeNodeWithoutLastModified[] |
| packages/ucd-store-v2/src/ | Updated types and interfaces to use new schema names |
| packages/test-utils/ | Updated mock types and test fixtures to use UnicodeFileTree |
| packages/shared/src/ | Consolidated file utilities into files.ts, removed flatten.ts, updated filter.ts |
| packages/shared/test/ | Migrated flatten tests to files.test.ts and updated filter tests |
| packages/schemas/src/ | Major refactoring: renamed schemas, added DeepOmit utility type, updated lastModified handling |
| packages/schemas/test/ | Added comprehensive test coverage for new schemas |
| packages/client/ | Updated schema imports and usage |
| apps/api/ | Updated route handlers to use new schemas and handle type transformations |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }).superRefine((data, ctx) => { | ||
| if (data.type === "directory" && !("children" in data)) { | ||
| ctx.addIssue({ | ||
| code: "custom", | ||
| message: "Directory nodes must include children.", | ||
| }); | ||
| } | ||
|
|
||
| if (data.type === "file" && "children" in data) { | ||
| ctx.addIssue({ | ||
| code: "custom", | ||
| message: "File nodes cannot have children.", | ||
| }); | ||
| } |
There was a problem hiding this comment.
The superRefine validation logic checks if directory nodes have children and if file nodes don't have children. However, this validation is redundant because the schema already defines these constraints through the union of UnicodeFileTreeDirectorySchema (which has children) and UnicodeFileTreeFileSchema (which doesn't). The Zod union will ensure that only the correct shape is accepted. Consider removing this superRefine to avoid duplicate validation.
| }).superRefine((data, ctx) => { | |
| if (data.type === "directory" && !("children" in data)) { | |
| ctx.addIssue({ | |
| code: "custom", | |
| message: "Directory nodes must include children.", | |
| }); | |
| } | |
| if (data.type === "file" && "children" in data) { | |
| ctx.addIssue({ | |
| code: "custom", | |
| message: "File nodes cannot have children.", | |
| }); | |
| } |
| export type DeepOmit<T, K extends PropertyKey> = T extends object | ||
| ? T extends any[] | ||
| ? DeepOmit<T[number], K>[] | ||
| : { | ||
| [P in Exclude<keyof T, K>]: DeepOmit<T[P], K>; | ||
| } | ||
| : T; |
There was a problem hiding this comment.
The DeepOmit utility type doesn't properly handle the case where T is an array. The current implementation T extends any[] ? DeepOmit<T[number], K>[] : ... will recursively omit from array elements but won't preserve array-specific properties correctly for union types like UnicodeFileTreeNode[]. This could lead to incorrect type inference when used with complex recursive structures. Consider testing this type thoroughly or using a well-tested utility library implementation.
| export type DeepOmit<T, K extends PropertyKey> = T extends object | |
| ? T extends any[] | |
| ? DeepOmit<T[number], K>[] | |
| : { | |
| [P in Exclude<keyof T, K>]: DeepOmit<T[P], K>; | |
| } | |
| : T; | |
| export type DeepOmit<T, K extends PropertyKey> = T extends ReadonlyArray<infer U> | |
| ? ReadonlyArray<DeepOmit<U, K>> | |
| : T extends object | |
| ? { | |
| [P in Exclude<keyof T, K>]: DeepOmit<T[P], K>; | |
| } | |
| : T; |
Greptile SummaryRenamed schemas from
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant API as API Route<br/>(v1_versions/$version.ts)
participant Traverse as apache-autoindex-parse<br/>(traverse)
participant Unicode as unicode.org
participant Schemas as @ucdjs/schemas<br/>(UnicodeFileTree*)
Client->>API: GET /api/v1/versions/{version}/file-tree
API->>API: Resolve version (latest → stable version)
API->>API: Map UCD version
API->>Traverse: traverse(unicode.org/Public/{version}/ucd)
Traverse->>Unicode: Fetch directory listing
Unicode-->>Traverse: HTML with file entries
Traverse->>Traverse: Parse entries (lastModified: number | undefined)
Traverse-->>API: Return tree structure
Note over API: Type cast: as UnicodeFileTree<br/>(undefined → null mismatch)
API->>Schemas: Expected: UnicodeFileTreeSchema<br/>(lastModified: number | null)
API-->>Client: JSON response with file tree
Note over Schemas: UnicodeFileTreeNodeSchema validates:<br/>- Directories must have children<br/>- Files cannot have children
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Fix all issues with AI Agents 🤖
In @pnpm-workspace.yaml:
- Line 61: The package entry "apache-autoindex-parse: 5.0.2" in
pnpm-workspace.yaml references a non-existent public release; update that entry
to a published version (for example change to "apache-autoindex-parse: 3.0.3")
or remove the explicit version and let the package.json specify it, or if you
intend to use a private registry, add/verify the registry configuration (and any
auth) so pnpm can resolve "apache-autoindex-parse" to the private 5.0.2 package.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/api/src/routes/v1_versions/$version.ts (1)
256-264: Type cast may maskundefinedvalues forlastModifiedat runtime.The comment acknowledges that
traversereturnslastModifiedasnumber | undefined, but the cast toUnicodeFileTreeassumes it's alwaysnumber. Iftraversereturns entries withundefinedforlastModified, the API will returnundefinedvalues despite the schema declaringnumber.Consider either:
- Transforming the result to ensure
lastModifiedis always a number (e.g., default to0orDate.now())- Updating the schema to allow
nullforlastModified🔎 Proposed fix to ensure lastModified is always a number
- // We cast the result to UnicodeFileTree because the traverse function - // returns entries that uses lastModified as `number | undefined`. - // But we can't use the `number | undefined` type in the API schema. - // So we need to return lastModified as `number | null` always. - return c.json(result as UnicodeFileTree, 200); + // Transform the result to ensure lastModified is always a number + // since traverse returns `number | undefined` but API schema requires `number` + const normalizeLastModified = (entries: typeof result): UnicodeFileTree => { + return entries.map(entry => ({ + ...entry, + lastModified: entry.lastModified ?? 0, + ...(entry.type === "directory" && entry.children + ? { children: normalizeLastModified(entry.children) } + : {}), + })) as UnicodeFileTree; + }; + return c.json(normalizeLastModified(result), 200);As per coding guidelines, remember to regenerate the OpenAPI spec by running
pnpm build:openapiafter changing API routes or Zod schemas.
🧹 Nitpick comments (5)
packages/client/test/resources/versions.test.ts (1)
141-143: Consider using consistentmockFetchsignature.This test uses the direct call signature
mockFetch("GET", url, handler)while other tests in this file use the array-wrapped formmockFetch([["GET", url, handler]]). Consider using a consistent pattern throughout the file for maintainability.packages/schemas/src/fs.ts (1)
38-42: Consider usingz.number().nullable()for conciseness.The current
z.number().or(z.null())works correctly, butz.number().nullable()is more idiomatic in Zod and produces the same result.🔎 Suggested change
const FileEntryBaseSchema = z.object({ name: z.string(), path: z.string(), - lastModified: z.number().or(z.null()), + lastModified: z.number().nullable(), });packages/schemas/src/unicode.ts (1)
170-190: The directory validation check may be redundant.The
superRefinecheck at line 177 (!("children" in data)) verifies directories have children, butUnicodeFileTreeDirectorySchemaalready enforceschildrenas a required field via.extend(). The Zod union parsing would fail before reachingsuperRefineifchildrenis missing from a directory node.The file check at line 184 is useful as a defensive measure since
FileEntryFileSchemadoesn't explicitly forbid extra properties.packages/shared/test/files.test.ts (1)
110-114: Redundant assertion.The
not.toEqualcheck on line 112 is redundant since line 113 already assertstoBeUndefined(). If the result is undefined, it inherently won't equal the object.Proposed simplification
const result = findFileByPath(files, "folder/nested.txt"); - expect(result).not.toEqual({ type: "file", name: "nested.txt", path: "/folder/nested.txt", lastModified: null }); expect(result).toBeUndefined();apps/api/test/routes/v1_versions/$version.test.ts (1)
29-44:expectedFilesvariable appears unused — consider removing or using it.The
expectedFilesarray is defined but not used in the current tests. Each test defines its own mock data inline. Consider either:
- Removing this unused variable
- Using it in the tests to reduce duplication
🔎 Proposed fix to remove unused variable
- const expectedFiles = [ - { type: "file", name: "file1.txt", path: "file1.txt", lastModified: 1755287100000 }, - { type: "file", name: "file2.txt", path: "file2.txt", lastModified: 1755287100000 }, - { - type: "directory", - name: "subdir", - path: "subdir/", - lastModified: 1755287100000, - }, - { - type: "directory", - name: "emoji", - path: "emoji/", - lastModified: 1755287100000, - }, - ] satisfies Entry[]; -
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (29)
apps/api/src/routes/v1_versions/$version.tsapps/api/test/routes/v1_versions/$version.test.tspackages/client/src/resources/versions.tspackages/client/test/resources/versions.test.tspackages/schemas/src/fs.tspackages/schemas/src/index.tspackages/schemas/src/types.tspackages/schemas/src/unicode.tspackages/schemas/test/api.test.tspackages/schemas/test/fs.test.tspackages/schemas/test/manifest.test.tspackages/schemas/test/unicode.test.tspackages/shared/src/files.tspackages/shared/src/filter.tspackages/shared/src/flatten.tspackages/shared/src/index.tspackages/shared/test/files.test.tspackages/shared/test/filter.test.tspackages/shared/test/flatten.test.tspackages/test-utils/src/mock-store/types.tspackages/test-utils/test/mock-store/mock-store.test.tspackages/ucd-store-v2/src/operations/files/tree.tspackages/ucd-store-v2/src/types.tspackages/ucd-store/src/store.tspackages/ucd-store/test/internal/files.test.tspackages/ucd-store/test/maintenance/analyze.test.tspackages/utils/src/index.tspnpm-workspace.yamlvscode/src/lib/files.ts
💤 Files with no reviewable changes (2)
- packages/shared/src/flatten.ts
- packages/shared/test/flatten.test.ts
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{test,spec}.?(c|m)[jt]s?(x)
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{test,spec}.?(c|m)[jt]s?(x): Import test utilities from #test-utils/* path aliases instead of @ucdjs/test-utils in test files to avoid build step requirements and prevent cyclic dependencies
Use testdir() from vitest-testdirs to create temporary test directories in filesystem tests
Use mockStoreApi() utility from #test-utils/mock-store for MSW-based mocking of the UCD API in test files
Files:
packages/ucd-store/test/maintenance/analyze.test.tspackages/schemas/test/unicode.test.tspackages/ucd-store/test/internal/files.test.tspackages/schemas/test/fs.test.tspackages/schemas/test/manifest.test.tspackages/shared/test/filter.test.tspackages/test-utils/test/mock-store/mock-store.test.tspackages/shared/test/files.test.tsapps/api/test/routes/v1_versions/$version.test.tspackages/schemas/test/api.test.tspackages/client/test/resources/versions.test.ts
apps/api/test/**/*.{test,spec}.?(c|m)[jt]s?(x)
📄 CodeRabbit inference engine (AGENTS.md)
Place API app tests in apps/api/test/routes/** for endpoint tests and apps/api/test/unit/** for unit tests with mocks
Files:
apps/api/test/routes/v1_versions/$version.test.ts
apps/api/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Regenerate OpenAPI spec by running 'pnpm build:openapi' after changing API routes or Zod schemas
Files:
apps/api/src/routes/v1_versions/$version.ts
apps/api/src/**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
apps/api/src/**/*.ts: Build API (apps/api) using Hono web framework with OpenAPI plugin (@hono/zod-openapi) and organize routes by version and type
Use Zod schemas for defining API route schemas and request/response types in the API application
Files:
apps/api/src/routes/v1_versions/$version.ts
apps/api/src/routes/**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Document API endpoints with OpenAPI annotations using @hono/zod-openapi decorators
Files:
apps/api/src/routes/v1_versions/$version.ts
🧠 Learnings (24)
📓 Common learnings
Learnt from: luxass
Repo: ucdjs/ucd PR: 6
File: packages/cli/src/cmd/codegen/fields.ts:68-82
Timestamp: 2025-05-04T11:52:22.858Z
Learning: User prefers to address the issue with Node.js API compatibility (`Dirent.parentPath` not being part of Node's API and the `recursive: true` option for `readdir` being only available in Node 21+) in a separate PR rather than the current one.
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Applies to **/*.{test,spec}.?(c|m)[jt]s?(x) : Use mockStoreApi() utility from #test-utils/mock-store for MSW-based mocking of the UCD API in test files
Applied to files:
packages/test-utils/src/mock-store/types.tspackages/ucd-store/test/maintenance/analyze.test.tspackages/ucd-store/test/internal/files.test.tspackages/schemas/test/fs.test.tspackages/schemas/test/manifest.test.tspackages/test-utils/test/mock-store/mock-store.test.tsapps/api/test/routes/v1_versions/$version.test.tspackages/schemas/test/api.test.tspackages/client/test/resources/versions.test.ts
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Applies to **/*.{test,spec}.?(c|m)[jt]s?(x) : Import test utilities from #test-utils/* path aliases instead of ucdjs/test-utils in test files to avoid build step requirements and prevent cyclic dependencies
Applied to files:
packages/test-utils/src/mock-store/types.tspackages/ucd-store/test/maintenance/analyze.test.tspackages/utils/src/index.tspackages/ucd-store/test/internal/files.test.tspackages/schemas/test/fs.test.tspackages/schemas/test/manifest.test.tspackages/shared/test/filter.test.tspackages/test-utils/test/mock-store/mock-store.test.tspackages/shared/test/files.test.tsapps/api/test/routes/v1_versions/$version.test.tspackages/client/test/resources/versions.test.ts
📚 Learning: 2025-06-09T05:10:32.105Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 45
File: packages/ucd-store/src/download.ts:24-24
Timestamp: 2025-06-09T05:10:32.105Z
Learning: In the ucd-store package refactor, picomatch was moved from direct usage in download.ts to internal usage within the createPathFilter function in filter.ts. The pattern format is still picomatch-compatible, so JSDoc comments referencing picomatch pattern format remain correct.
Applied to files:
packages/test-utils/src/mock-store/types.tspackages/ucd-store/test/maintenance/analyze.test.tspackages/shared/src/index.tspackages/utils/src/index.tspackages/ucd-store/src/store.tspackages/ucd-store/test/internal/files.test.tspackages/ucd-store-v2/src/types.tspackages/schemas/test/fs.test.tspackages/schemas/test/manifest.test.tspackages/shared/test/filter.test.tspackages/test-utils/test/mock-store/mock-store.test.tspackages/ucd-store-v2/src/operations/files/tree.tsapps/api/test/routes/v1_versions/$version.test.tspackages/shared/src/filter.tspackages/schemas/src/fs.tspackages/client/test/resources/versions.test.tspackages/shared/src/files.ts
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Applies to packages/*/tsconfig.json : Use ucdjs-tooling/tsconfig for TypeScript configuration in new packages
Applied to files:
packages/ucd-store/test/maintenance/analyze.test.tspackages/ucd-store/test/internal/files.test.tspackages/ucd-store-v2/src/types.ts
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Use File System Bridge Pattern (ucdjs/fs-bridge) abstraction for file system operations to support multiple backends (Node.js, HTTP, in-memory)
Applied to files:
packages/ucd-store/test/maintenance/analyze.test.tspackages/ucd-store/src/store.tspackages/ucd-store-v2/src/types.ts
📚 Learning: 2025-07-13T09:23:43.820Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 107
File: apps/api/src/routes/v1_files.ts:18-32
Timestamp: 2025-07-13T09:23:43.820Z
Learning: UNICODE_STABLE_VERSION from luxass/unicode-utils-new refers to a specific Unicode version string (not a dynamic value), and the validation logic in the files API correctly checks the normalized version (after "latest" substitution) against UNICODE_VERSION_METADATA rather than the mappedVersion from resolveUCDVersion().
Applied to files:
packages/ucd-store/test/maintenance/analyze.test.tspackages/schemas/test/unicode.test.tspackages/ucd-store/test/internal/files.test.tspackages/client/src/resources/versions.tspackages/test-utils/test/mock-store/mock-store.test.tsapps/api/test/routes/v1_versions/$version.test.tspackages/schemas/src/index.tspackages/client/test/resources/versions.test.tsapps/api/src/routes/v1_versions/$version.tspackages/schemas/src/unicode.ts
📚 Learning: 2025-05-04T11:52:22.858Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 6
File: packages/cli/src/cmd/codegen/fields.ts:68-82
Timestamp: 2025-05-04T11:52:22.858Z
Learning: User prefers to address the issue with Node.js API compatibility (`Dirent.parentPath` not being part of Node's API and the `recursive: true` option for `readdir` being only available in Node 21+) in a separate PR rather than the current one.
Applied to files:
packages/shared/src/index.tspackages/utils/src/index.tspackages/shared/test/filter.test.tspackages/ucd-store-v2/src/operations/files/tree.tsapps/api/test/routes/v1_versions/$version.test.tspackages/shared/src/files.ts
📚 Learning: 2025-07-20T05:37:40.565Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 131
File: tooling/eslint-plugin/package.json:0-0
Timestamp: 2025-07-20T05:37:40.565Z
Learning: In the ucdjs/ucd project, internal tooling packages (private packages in the tooling/ directory) export TypeScript files directly without requiring a build step, unlike published packages which use tsdown to build and export from ./dist/. Examples include ucdjs/tsdown-config and ucdjs/eslint-plugin.
Applied to files:
packages/utils/src/index.tspackages/ucd-store/src/store.tspackages/ucd-store/test/internal/files.test.tspackages/ucd-store-v2/src/types.ts
📚 Learning: 2025-08-17T10:06:18.009Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 206
File: packages/ucd-store/src/internal/repair.ts:88-96
Timestamp: 2025-08-17T10:06:18.009Z
Learning: The internal__clean function in ucdjs/ucd-store can be safely called with versions: [] and a directories parameter to clean up only specific directories without processing any version files or modifying the manifest. When versions is empty, the analysis returns no results, skipping all file deletion logic, but the directory cleanup section still processes directories from the directories parameter.
Applied to files:
packages/ucd-store/src/store.ts
📚 Learning: 2025-06-29T11:20:13.668Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 87
File: packages/worker-shared/tsconfig.build.json:1-4
Timestamp: 2025-06-29T11:20:13.668Z
Learning: In the ucdjs/ucd project, the packages use tsdown instead of tsc for building libraries. The tsconfig.build.json files are primarily for IDE experience and type checking, not for direct compilation, so including "test" directories in these configs doesn't affect build output.
Applied to files:
packages/ucd-store/test/internal/files.test.tspackages/test-utils/test/mock-store/mock-store.test.ts
📚 Learning: 2025-08-23T05:20:36.940Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 209
File: packages/ucd-store/test/clean.test.ts:9-9
Timestamp: 2025-08-23T05:20:36.940Z
Learning: In the ucdjs/ucd codebase using modern Vitest, the assert export from "vitest" works as a callable function assert(condition, message) and provides TypeScript type narrowing, making it the preferred choice over expect() for runtime assertions that need compile-time type safety. The existing usage pattern assert(condition, message) throughout the test suite is working correctly.
Applied to files:
packages/schemas/test/fs.test.tspackages/schemas/test/manifest.test.tspackages/shared/test/filter.test.tspackages/test-utils/test/mock-store/mock-store.test.tspackages/schemas/test/api.test.ts
📚 Learning: 2025-08-23T05:20:36.940Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 209
File: packages/ucd-store/test/clean.test.ts:9-9
Timestamp: 2025-08-23T05:20:36.940Z
Learning: In the ucdjs/ucd codebase, Vitest's assert import works as a callable function assert(condition, message) and provides TypeScript type narrowing, making it the preferred choice over expect() for runtime assertions that also need compile-time type safety.
Applied to files:
packages/schemas/test/manifest.test.tspackages/test-utils/test/mock-store/mock-store.test.ts
📚 Learning: 2025-08-23T05:16:26.866Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 209
File: packages/ucd-store/test/clean.test.ts:9-9
Timestamp: 2025-08-23T05:16:26.866Z
Learning: In the ucdjs/ucd codebase, the team prefers using `assert(condition, message)` over `expect(condition).toBeTruthy()` because assert provides TypeScript type narrowing while expect doesn't. This is important for maintaining type safety after runtime validation checks.
Applied to files:
packages/schemas/test/manifest.test.ts
📚 Learning: 2025-10-14T07:15:35.199Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 326
File: packages/shared/src/ucd-config.ts:34-58
Timestamp: 2025-10-14T07:15:35.199Z
Learning: In packages/shared/src/ucd-config.ts, the `getDefaultUCDEndpointConfig` function uses a build-time define `__UCD_ENDPOINT_DEFAULT_CONFIG__` that is replaced at build time by the bundler. The `??` operator is evaluated at build time, so the final code contains no runtime branching. Therefore, runtime unit tests for this function are not valuable—the build process itself handles the injection and fallback logic.
Applied to files:
packages/test-utils/test/mock-store/mock-store.test.tsapps/api/test/routes/v1_versions/$version.test.tspackages/client/test/resources/versions.test.ts
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Applies to apps/api/test/**/*.{test,spec}.?(c|m)[jt]s?(x) : Place API app tests in apps/api/test/routes/** for endpoint tests and apps/api/test/unit/** for unit tests with mocks
Applied to files:
packages/shared/test/files.test.tspackages/schemas/test/api.test.ts
📚 Learning: 2025-06-14T05:20:20.149Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 56
File: packages/utils/src/ucd-files/validate.ts:115-130
Timestamp: 2025-06-14T05:20:20.149Z
Learning: Node.js 22 supports the `recursive` option in `fs.readdir()` (introduced in Node.js 18.17.0), which returns a flattened string array of all descendant files and directories when `recursive: true` is passed.
Applied to files:
packages/shared/test/files.test.tspackages/shared/src/files.ts
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Applies to apps/api/src/**/*.ts : Build API (apps/api) using Hono web framework with OpenAPI plugin (hono/zod-openapi) and organize routes by version and type
Applied to files:
apps/api/test/routes/v1_versions/$version.test.tsapps/api/src/routes/v1_versions/$version.ts
📚 Learning: 2025-07-01T04:10:40.989Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 89
File: apps/api/src/routes/v1_files.ts:42-43
Timestamp: 2025-07-01T04:10:40.989Z
Learning: The `traverse` method from the `apache-autoindex-parse` library always returns an array, even when HTTP requests fail or encounter network errors. Network failures are handled internally by the library rather than throwing exceptions, so catch blocks are primarily for parsing errors or unexpected JavaScript runtime errors.
Applied to files:
apps/api/test/routes/v1_versions/$version.test.ts
📚 Learning: 2025-07-01T04:10:40.989Z
Learnt from: luxass
Repo: ucdjs/ucd PR: 89
File: apps/api/src/routes/v1_files.ts:42-43
Timestamp: 2025-07-01T04:10:40.989Z
Learning: The `traverse` method from the `apache-autoindex-parse` library always returns an array, even when HTTP requests fail or encounter network errors. The method handles request failures internally rather than throwing exceptions.
Applied to files:
apps/api/test/routes/v1_versions/$version.test.ts
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Applies to apps/api/src/**/*.ts : Use Zod schemas for defining API route schemas and request/response types in the API application
Applied to files:
packages/schemas/test/api.test.tspackages/schemas/src/fs.tsapps/api/src/routes/v1_versions/$version.tspackages/schemas/src/unicode.ts
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Require Node.js >= 22.18 and pnpm 10.26.1 for development in this project
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Applies to apps/api/src/routes/**/*.ts : Document API endpoints with OpenAPI annotations using hono/zod-openapi decorators
Applied to files:
apps/api/src/routes/v1_versions/$version.ts
📚 Learning: 2025-12-27T11:08:54.630Z
Learnt from: CR
Repo: ucdjs/ucd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-27T11:08:54.630Z
Learning: Applies to apps/api/src/**/*.{ts,tsx} : Regenerate OpenAPI spec by running 'pnpm build:openapi' after changing API routes or Zod schemas
Applied to files:
apps/api/src/routes/v1_versions/$version.ts
🧬 Code graph analysis (10)
packages/ucd-store-v2/src/types.ts (2)
packages/ucd-store-v2/src/operations/files/tree.ts (1)
GetFileTreeOptions(15-21)packages/shared/src/async/try-catch.ts (1)
OperationResult(7-7)
packages/schemas/test/fs.test.ts (2)
packages/schemas/src/index.ts (3)
FileEntrySchema(5-5)FileEntryListSchema(4-4)UCDStoreManifestSchema(6-6)packages/schemas/src/fs.ts (3)
FileEntrySchema(52-62)FileEntryListSchema(85-88)UCDStoreManifestSchema(4-34)
packages/test-utils/test/mock-store/mock-store.test.ts (2)
packages/ucd-store-v2/src/store.ts (1)
tree(165-167)packages/test-utils/src/msw.ts (1)
HttpResponse(11-11)
packages/ucd-store-v2/src/operations/files/tree.ts (1)
packages/shared/src/async/try-catch.ts (1)
OperationResult(7-7)
packages/shared/test/files.test.ts (1)
packages/shared/src/files.ts (2)
findFileByPath(12-31)flattenFilePaths(53-73)
apps/api/test/routes/v1_versions/$version.test.ts (3)
packages/test-utils/src/msw.ts (1)
mockFetch(16-19)apps/api/test/helpers/request.ts (2)
json(33-35)executeRequest(15-40)apps/api/wrangler-types.d.ts (1)
env(10237-10237)
packages/schemas/src/fs.ts (1)
packages/schemas/src/index.ts (1)
FileEntrySchema(5-5)
apps/api/src/routes/v1_versions/$version.ts (2)
apps/api/src/routes/v1_versions/utils.ts (1)
calculateStatistics(141-199)apps/api/src/types.ts (1)
HonoEnv(1-3)
packages/shared/src/files.ts (2)
packages/shared/src/index.ts (2)
findFileByPath(8-8)flattenFilePaths(8-8)tooling/moonbeam/src/esm-loader.mjs (1)
entries(44-44)
packages/schemas/src/unicode.ts (2)
packages/schemas/src/fs.ts (2)
FileEntryFileSchema(48-50)FileEntryDirectorySchema(44-46)packages/schemas/src/types.ts (1)
DeepOmit(1-7)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Agent
- GitHub Check: Greptile Review
- GitHub Check: test (macos-latest)
- GitHub Check: test (windows-latest)
🔇 Additional comments (65)
packages/utils/src/index.ts (1)
2-2: TreeEntry removal from public API is safe and verified.The removal of
TreeEntryfrompackages/utils/src/index.tsexports is confirmed safe. Comprehensive search shows no imports or usages of this type exist in the codebase, andTreeEntryno longer exists in the shared package. The change aligns with the broader schema refactoring objectives.packages/ucd-store/test/maintenance/analyze.test.ts (2)
1-1: LGTM: Schema rename correctly applied.The import change from
UnicodeTreetoUnicodeFileTreealigns with the PR's schema refactoring objectives.
14-41: LGTM: Type assertion correctly updated.The
MOCK_FILEStype assertion has been properly updated to useUnicodeFileTree, maintaining consistency with the import change. The mock data structure correctly represents a file tree with all required fields.pnpm-workspace.yaml (1)
56-56: No issues found; zod 4.3.5 is a safe patch-version update.Zod 4.3.5 exists and has no known security vulnerabilities. This is a patch version update within 4.x, which carries minimal risk.
packages/schemas/src/types.ts (1)
1-7: LGTM!The
DeepOmitutility type is well-implemented. It correctly handles the three cases: arrays (recursively applies to elements), objects (excludes specified keys and recurses on values), and primitives (returns as-is). This is a clean approach for creatingUnicodeFileTreeNodeWithoutLastModified.packages/client/test/resources/versions.test.ts (2)
1-6: LGTM!Good use of
#test-utils/mswpath alias for test utilities as per coding guidelines. The import ofUCDJS_API_BASE_URLfrom@ucdjs/envcentralizes the base URL configuration appropriately.
33-44: LGTM!Mock data correctly includes the
lastModifiedfield on all file tree entries, aligning with the updatedUnicodeFileTreeSchemastructure.packages/schemas/src/fs.ts (4)
4-14: LGTM!The
UCDStoreManifestSchemastructure with nested defaults is well-designed. The outer.default({})ensures missing version keys get the default object withexpectedFiles: [].
44-62: LGTM!Clean schema composition using
extend()for the directory and file variants, and proper union with descriptive metadata.
63-81: Noted: Deferred validation for path conventions.The commented
superRefinevalidation for path conventions (leading slash, trailing slash for directories) is appropriately marked as a TODO pending #420. The comments clearly explain the intended behavior.
85-90: LGTM!
FileEntryListSchemawith proper meta and type export provides a clean public API for array validation.packages/schemas/src/unicode.ts (5)
1-3: LGTM!Clean imports establishing the dependency on the new
DeepOmittype and shared file entry schemas from./fs.
64-94: LGTM!The manual interface definitions correctly mirror the Zod schema structure. The comment explaining the Hono ZOD OpenAPI limitation for recursive types provides good context for this design decision.
116-125: LGTM!Providing default zero values for statistics makes the API more ergonomic by eliminating null checks while preserving semantic clarity (zeros indicate missing/unknown data).
153-168: LGTM!The recursive schema definition using
z.lazy()is the correct pattern for self-referential types. The explicit type annotation onUnicodeFileTreeDirectorySchemaand the OpenAPI$refhint in meta ensure proper type inference and documentation generation.
192-201: LGTM!Clean type exports. The
UnicodeFileTreeNodeWithoutLastModifiedtype correctly usesDeepOmitto recursively striplastModifiedfrom the tree structure, which is useful for the VSCode extension and other consumers that don't need modification timestamps.vscode/src/lib/files.ts (1)
1-10: LGTM!The type change from
UnicodeTreeNodetoUnicodeFileTreeNodeWithoutLastModifiedcorrectly reflects that the VSCode extension doesn't needlastModifiedmetadata for tree rendering. This is a clean type-only migration with no runtime behavior changes.packages/client/src/resources/versions.ts (2)
5-5: LGTM!Import correctly updated to use the renamed
UnicodeFileTreeSchema.
44-51: LGTM!The
getFileTreemethod correctly uses the renamedUnicodeFileTreeSchemafor response validation, maintaining consistency with the schema refactor.packages/shared/test/filter.test.ts (5)
1-3: LGTM!Imports are minimal and focused. The removal of the
TreeEntrytype import (previously used for test data typing) aligns with the schema refactor.
674-719: LGTM!Test fixtures correctly use
as constassertions for type literals, enabling proper type inference without requiring explicit type imports. The test data appropriately omitslastModifiedsince the filter logic operates on path patterns, not timestamps.
881-885: LGTM!Consistent use of
as constassertions in this test fixture.
896-919: LGTM!Nested structure test fixture correctly updated with
as constassertions.
1038-1073: LGTM!Edge case test fixture for files without extensions properly uses
as constassertions.packages/shared/src/index.ts (1)
8-9: LGTM! Public API updated for file-tree refactor.The new exports
findFileByPathandflattenFilePathsreplace the previousflattenandTreeEntrysurface, aligning with the broader UnicodeTree → UnicodeFileTree migration across the codebase.packages/ucd-store/test/internal/files.test.ts (1)
1-1: LGTM! Type imports updated correctly.The test now uses
UnicodeFileTreetype to match the refactored schemas. The mock response data appropriately includeslastModifiedfields for the new schema structure.Also applies to: 42-42
packages/test-utils/src/mock-store/types.ts (1)
2-2: LGTM! Mock store types aligned with schema refactor.The
MockStoreFilestype now correctly usesUnicodeFileTreeinstead ofUnicodeTree, maintaining consistency with the updated schemas throughout the codebase.Also applies to: 84-84
packages/ucd-store-v2/src/types.ts (1)
4-4: LGTM! File-tree operation types updated correctly.The
treemethod now returnsUnicodeFileTreeNodeWithoutLastModified[], accurately reflecting the schema refactor. The type name clearly indicates thatlastModifiedis excluded from the nodes returned by this operation.Also applies to: 173-173
packages/ucd-store/src/store.ts (1)
4-4: LGTM! Store method signature updated for schema refactor.The
getFileTreemethod now correctly returnsUnicodeFileTreeNodeWithoutLastModified[], maintaining consistency with the updated schemas and the v2 store implementation.Also applies to: 142-142
packages/shared/test/files.test.ts (2)
1-4: LGTM! Imports are appropriate.The imports are correctly using
@ucdjs/schemasfor the type andvitestfor testing. No test utilities from the repository are needed here, so the imports comply with the coding guidelines.
206-437: LGTM! Comprehensive test coverage for flattenFilePaths.The test suite covers a wide range of scenarios including edge cases (empty arrays, empty directories), nested structures, and the prefix parameter behavior. The test data correctly reflects the
UnicodeFileTreeNodeWithoutLastModifiedconstraint used by the implementation.packages/schemas/test/manifest.test.ts (1)
1-87: LGTM! Well-structured schema validation tests.The test suite thoroughly covers validation scenarios for
UCDStoreVersionManifestSchemaincluding valid cases (with files, empty array, nested paths) and rejection cases (missing field, wrong type, non-string elements). The use oftoMatchSchemacustom matcher is consistent with other test files in the PR.packages/schemas/test/fs.test.ts (4)
1-4: LGTM! Imports and setup are correct.The imports correctly bring in the schemas from
../src/fsand the type reference directive ensures the custom matcher types are available.
7-85: LGTM! FileEntrySchema tests are comprehensive.Good coverage of valid entries (directory, file) and invalid cases (missing fields, invalid type, missing name/path). The mix of
toMatchSchemafor detailed assertions andsafeParsefor simple rejection checks is appropriate.
87-135: LGTM! FileEntryListSchema tests cover essential cases.The tests verify valid lists, empty lists, and rejection of lists containing invalid entries.
137-211: LGTM! UCDStoreManifestSchema tests are thorough.The tests correctly validate the record-based manifest structure where each version key maps to an object with
expectedFiles. The default value behavior (empty array whenexpectedFilesis missing) is properly tested, aligning with the schema definition using.default([]).packages/schemas/test/unicode.test.ts (4)
1-10: LGTM! Imports correctly reference the renamed schemas.The imports properly use the new
UnicodeFileTreeNodeSchemaandUnicodeFileTreeSchemanames, consistent with the PR's schema renaming fromUnicodeTree*toUnicodeFileTree*.
11-131: LGTM! UnicodeVersionSchema tests are comprehensive.Excellent coverage of all version types (stable, draft, unsupported), mapped UCD versions, and rejection cases for invalid data formats.
168-300: LGTM! UnicodeFileTreeNodeSchema tests validate structural constraints.The tests correctly verify that:
lastModifiedis required (even if nullable)- Files cannot have
children- Directories must have
children- Nested structures are properly validated
302-407: LGTM! UnicodeFileTreeSchema and UnicodeVersionDetailsSchema tests.The tests cover essential validation scenarios including tree structure validation, default statistics handling, and rejection of invalid (negative) statistics values.
packages/shared/src/files.ts (2)
1-31: LGTM! findFileByPath implementation is correct.The function correctly:
- Falls back to
nameifpathis undefined- Recursively searches directory children
- Returns the matching node or undefined
The type-safe generic approach works well with the
UnicodeFileTreeNodeWithoutLastModifiedconstraint.
53-73: LGTM! flattenFilePaths implementation is correct.The function correctly:
- Validates input is an array
- Uses
prependLeadingSlashfor consistent path formatting with prefix- Recursively processes directory children
- Only collects file paths (not directory paths)
The
prefixparameter is designed for prepending a base path (like a URL prefix) rather than building paths from directory names, which makes sense given that each node already has a completepathproperty.packages/schemas/test/api.test.ts (3)
1-4: LGTM! Test file setup is correct.The imports and type reference directive are properly configured for testing the API schemas.
7-71: LGTM! ApiErrorSchema tests are well-structured.Good use of
it.eachfor parameterized testing of HTTP status codes, and comprehensive coverage of validation scenarios including missing fields and type mismatches.
73-195: LGTM! UCDWellKnownConfigSchema tests are thorough.The tests correctly validate:
- Complete configuration with all fields
- Default values when optional fields are omitted
- Rejection of missing/incomplete endpoints
- Type validation for version and versions fields
packages/schemas/src/index.ts (1)
17-31: Schema exports correctly renamed to UnicodeFileTree.*The exports properly reflect the PR's schema renaming:
UnicodeTreeNodeSchema→UnicodeFileTreeNodeSchemaUnicodeTreeSchema→UnicodeFileTreeSchema- Added new type
UnicodeFileTreeNodeWithoutLastModifiedAll internal usages throughout the codebase have been updated accordingly. The new type is actively used across packages (vscode, ucd-store-v2, shared, ucd-store) in filters, type constraints, and operation return types.
Note: This is a breaking change for external consumers using the old export names.
packages/test-utils/test/mock-store/mock-store.test.ts (4)
1-6: LGTM!The import update from
UnicodeTreetoUnicodeFileTreecorrectly reflects the schema rename, and test utilities are properly imported from#test-utils/*path aliases as per coding guidelines.
199-223: LGTM!The test correctly uses
UnicodeFileTreetype, includes the requiredlastModifiedfield, and properly types theHttpResponse.jsongeneric parameter.
409-439: LGTM!The
customTreevariable is properly typed asUnicodeFileTreewith the requiredlastModifiedfield.
976-1026: LGTM!Good use of
Date.now()for thelastModifiedfield to provide realistic test data, and the test properly validates the hook behavior with the updatedUnicodeFileTreetype.packages/ucd-store-v2/src/operations/files/tree.ts (2)
1-4: LGTM!The import update to
UnicodeFileTreeNodeWithoutLastModifiedcorrectly reflects the schema changes. This type appropriately represents file tree nodes in the store context wherelastModifiedmay not always be available from local filesystem operations.
31-37: LGTM!The JSDoc and function signature correctly reflect the updated return type. The type is consistent with the
store.tsimplementation at lines 141-163 which uses the sameUnicodeFileTreeNodeWithoutLastModified[]type.apps/api/src/routes/v1_versions/$version.ts (4)
1-6: LGTM!Import updates correctly reflect the schema renames. Using Zod schemas for API route definitions follows the coding guidelines for the API application.
112-112: LGTM!Schema correctly updated to
UnicodeFileTreeSchemafor the OpenAPI response definition.
212-231: Statistics are now always returned with defaults — verify this is intentional.The statistics object is now always included in the response with default zero values, even when
calculateStatisticsreturnsnull(e.g., when bucket is unavailable or files are missing). This is a behavior change from potentially returningundefinedstatistics.This approach ensures consistent API response shape, which is good for clients. However, consumers should be aware that zero values may indicate "not available" rather than "actually zero."
236-237: LGTM!Registering
UnicodeFileTreeNodein the OpenAPI registry ensures proper schema documentation for the recursive tree structure.apps/api/test/routes/v1_versions/$version.test.ts (6)
1-10: LGTM!Imports correctly use
#test-utils/*path aliases per coding guidelines, and theflattenFilePathsutility from@ucdjs-internal/sharedenables cleaner assertions on nested file tree structures.
46-93: LGTM!Good test coverage with proper mocking of the recursive directory traversal. Using
flattenFilePathsfor assertions makes the test more readable and maintainable.
95-142: LGTM!Good test coverage for the
latestversion alias, correctly mocking the resolved version endpoints.
182-193: LGTM!Good use of
reducewith proper type assertions to separate file and directory entries for structural validation.
266-304: LGTM!Error handling tests correctly validate the structured error response format with the
error.messageproperty.
310-370: LGTM!Cache tests are appropriately marked as
todowith a clear explanation of the Vitest Pool Workers caching issues. The test structure is solid and will be ready when the underlying issue is resolved.packages/shared/src/filter.ts (3)
1-4: LGTM!Import correctly updated to use
UnicodeFileTreeNodeWithoutLastModifiedas the base type constraint for the generic filter function.
200-206: LGTM!Good use of generics to make
filterTreeStructurereusable with different node types while preserving the input type in the output. This allows the function to work with bothUnicodeFileTreeandUnicodeFileTreeNodeWithoutLastModified[]types.
208-245: No changes needed—the generic type implementation is correct.The code properly handles type preservation for nested children. The
DeepOmit<UnicodeFileTreeNode, "lastModified">type recursively removeslastModifiedat all nesting levels, including within thechildrenarrays. WhenT extends UnicodeFileTreeNodeWithoutLastModified, theentry.childrenproperty is correctly typed asUnicodeFileTreeNodeWithoutLastModified[], which satisfies the recursive call's generic constraint. The spread operator at line 236 correctly preserves the type while overriding thechildrenproperty with the filtered results.
🔗 Linked issue
📚 Description
This PR renames the schemas, and fixes that broke when changing the schemas.
Some schemas like the lockfile, and the superRefine will be added in a separate PR.
Summary by CodeRabbit
New Features
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.